Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

Issue 2644783003: Regenerate MANIFEST.json when WPT tests are run (Closed)
Patch Set: Simplify MANIFEST.json regeneration, just say the file might have changed Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
index 7ef3b7809cf11ec3348c7533041bf86a9117304d..ff658bb0b8f2d4f8fefde5a55115addb602d874c 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
@@ -297,6 +297,12 @@ class PortTest(unittest.TestCase):
self.assertEqual(port.tests(['external/wpt/dom/ranges/Range-attributes.html']),
['external/wpt/dom/ranges/Range-attributes.html'])
+ # Assert manifest was regenerated only once (testing memoization).
+ self.assertEqual(port.host.executive.calls, [
+ ['/mock-checkout/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest',
+ '--work', '--tests-root', '/mock-checkout/third_party/WebKit/LayoutTests/external/wpt']
+ ])
+
def test_is_test_file(self):
port = self.make_port(with_tests=True)
is_test_file = functools.partial(Port.is_test_file, port, port.host.filesystem)

Powered by Google App Engine
This is Rietveld 408576698