third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py - Issue 2644783003: Regenerate MANIFEST.json when WPT tests are run

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

Issue 2644783003: Regenerate MANIFEST.json when WPT tests are run (Closed)

Patch Set: Simplify MANIFEST.json regeneration, just say the file might have changed Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

index 7ef3b7809cf11ec3348c7533041bf86a9117304d..ff658bb0b8f2d4f8fefde5a55115addb602d874c 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

@@ -297,6 +297,12 @@ class PortTest(unittest.TestCase):

self.assertEqual(port.tests(['external/wpt/dom/ranges/Range-attributes.html']),

['external/wpt/dom/ranges/Range-attributes.html'])

+ # Assert manifest was regenerated only once (testing memoization).

+ self.assertEqual(port.host.executive.calls, [

+ ['/mock-checkout/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest',

+ '--work', '--tests-root', '/mock-checkout/third_party/WebKit/LayoutTests/external/wpt']

+ ])

def test_is_test_file(self):

port = self.make_port(with_tests=True)

is_test_file = functools.partial(Port.is_test_file, port, port.host.filesystem)