Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

Issue 2644783003: Regenerate MANIFEST.json when WPT tests are run (Closed)
Patch Set: Simplify MANIFEST.json regeneration, just say the file might have changed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 self.assertIn('external/wpt/dom/ranges/Range-attributes.html', port.test s([])) 290 self.assertIn('external/wpt/dom/ranges/Range-attributes.html', port.test s([]))
291 self.assertNotIn('external/wpt/console/console-is-a-namespace.any.js', p ort.tests([])) 291 self.assertNotIn('external/wpt/console/console-is-a-namespace.any.js', p ort.tests([]))
292 self.assertEqual(port.tests(['external']), ['external/wpt/dom/ranges/Ran ge-attributes.html']) 292 self.assertEqual(port.tests(['external']), ['external/wpt/dom/ranges/Ran ge-attributes.html'])
293 self.assertEqual(port.tests(['external/']), ['external/wpt/dom/ranges/Ra nge-attributes.html']) 293 self.assertEqual(port.tests(['external/']), ['external/wpt/dom/ranges/Ra nge-attributes.html'])
294 self.assertEqual(port.tests(['external/csswg-test']), []) 294 self.assertEqual(port.tests(['external/csswg-test']), [])
295 self.assertEqual(port.tests(['external/wpt']), ['external/wpt/dom/ranges /Range-attributes.html']) 295 self.assertEqual(port.tests(['external/wpt']), ['external/wpt/dom/ranges /Range-attributes.html'])
296 self.assertEqual(port.tests(['external/wpt/']), ['external/wpt/dom/range s/Range-attributes.html']) 296 self.assertEqual(port.tests(['external/wpt/']), ['external/wpt/dom/range s/Range-attributes.html'])
297 self.assertEqual(port.tests(['external/wpt/dom/ranges/Range-attributes.h tml']), 297 self.assertEqual(port.tests(['external/wpt/dom/ranges/Range-attributes.h tml']),
298 ['external/wpt/dom/ranges/Range-attributes.html']) 298 ['external/wpt/dom/ranges/Range-attributes.html'])
299 299
300 # Assert manifest was regenerated only once (testing memoization).
301 self.assertEqual(port.host.executive.calls, [
302 ['/mock-checkout/third_party/WebKit/Tools/Scripts/webkitpy/thirdpart y/wpt/wpt/manifest',
303 '--work', '--tests-root', '/mock-checkout/third_party/WebKit/Layout Tests/external/wpt']
304 ])
305
300 def test_is_test_file(self): 306 def test_is_test_file(self):
301 port = self.make_port(with_tests=True) 307 port = self.make_port(with_tests=True)
302 is_test_file = functools.partial(Port.is_test_file, port, port.host.file system) 308 is_test_file = functools.partial(Port.is_test_file, port, port.host.file system)
303 self.assertTrue(is_test_file('', 'foo.html')) 309 self.assertTrue(is_test_file('', 'foo.html'))
304 self.assertTrue(is_test_file('', 'foo.svg')) 310 self.assertTrue(is_test_file('', 'foo.svg'))
305 self.assertTrue(is_test_file('', 'test-ref-test.html')) 311 self.assertTrue(is_test_file('', 'test-ref-test.html'))
306 self.assertTrue(is_test_file('inspector-unit', 'trie.js')) 312 self.assertTrue(is_test_file('inspector-unit', 'trie.js'))
307 self.assertFalse(is_test_file('inspector-unit', 'foo.html')) 313 self.assertFalse(is_test_file('inspector-unit', 'foo.html'))
308 self.assertFalse(is_test_file('inspector', 'devtools.js')) 314 self.assertFalse(is_test_file('inspector', 'devtools.js'))
309 self.assertFalse(is_test_file('', 'foo.png')) 315 self.assertFalse(is_test_file('', 'foo.png'))
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
643 self.assertEqual(suite.args, ['--args']) 649 self.assertEqual(suite.args, ['--args'])
644 self.assertEqual(suite.reference_args, []) 650 self.assertEqual(suite.reference_args, [])
645 651
646 def test_non_default_reference_args(self): 652 def test_non_default_reference_args(self):
647 suite = VirtualTestSuite(prefix='suite', base='base/foo', args=['--args' ], references_use_default_args=False) 653 suite = VirtualTestSuite(prefix='suite', base='base/foo', args=['--args' ], references_use_default_args=False)
648 self.assertEqual(suite.args, ['--args']) 654 self.assertEqual(suite.args, ['--args'])
649 self.assertEqual(suite.reference_args, suite.args) 655 self.assertEqual(suite.reference_args, suite.args)
650 656
651 def test_no_slash(self): 657 def test_no_slash(self):
652 self.assertRaises(AssertionError, VirtualTestSuite, prefix='suite/bar', base='base/foo', args=['--args']) 658 self.assertRaises(AssertionError, VirtualTestSuite, prefix='suite/bar', base='base/foo', args=['--args'])
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698