Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: content/browser/media/media_browsertest.cc

Issue 2644773002: media: Disable the flaky bear.mp4 browser test on Android (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/media/media_browsertest.h" 5 #include "content/browser/media/media_browsertest.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 IN_PROC_BROWSER_TEST_P(MediaTest, VideoBearHighBitDepthVP9) { 135 IN_PROC_BROWSER_TEST_P(MediaTest, VideoBearHighBitDepthVP9) {
136 PlayVideo("bear-320x180-hi10p-vp9.webm", GetParam()); 136 PlayVideo("bear-320x180-hi10p-vp9.webm", GetParam());
137 } 137 }
138 138
139 IN_PROC_BROWSER_TEST_P(MediaTest, VideoBear12DepthVP9) { 139 IN_PROC_BROWSER_TEST_P(MediaTest, VideoBear12DepthVP9) {
140 PlayVideo("bear-320x180-hi12p-vp9.webm", GetParam()); 140 PlayVideo("bear-320x180-hi12p-vp9.webm", GetParam());
141 } 141 }
142 #endif 142 #endif
143 143
144 #if defined(USE_PROPRIETARY_CODECS) 144 #if defined(USE_PROPRIETARY_CODECS)
145 // Crashes on Mac only. http://crbug.com/621857 145 // Crashes on Mac http://crbug.com/621857
146 #if defined(OS_MACOSX) 146 // Fails on Android http://crbug.com/682387
147 #if defined(OS_MACOSX) || defined(OS_ANDROID)
147 #define MAYBE_VideoBearMp4 DISABLED_VideoBearMp4 148 #define MAYBE_VideoBearMp4 DISABLED_VideoBearMp4
148 #else 149 #else
149 #define MAYBE_VideoBearMp4 VideoBearMp4 150 #define MAYBE_VideoBearMp4 VideoBearMp4
150 #endif 151 #endif
151 IN_PROC_BROWSER_TEST_P(MediaTest, MAYBE_VideoBearMp4) { 152 IN_PROC_BROWSER_TEST_P(MediaTest, MAYBE_VideoBearMp4) {
152 PlayVideo("bear.mp4", GetParam()); 153 PlayVideo("bear.mp4", GetParam());
153 } 154 }
154 155
155 IN_PROC_BROWSER_TEST_P(MediaTest, VideoBearMp4Vp9) { 156 IN_PROC_BROWSER_TEST_P(MediaTest, VideoBearMp4Vp9) {
156 PlayVideo("bear-320x240-v_frag-vp9.mp4", GetParam()); 157 PlayVideo("bear-320x240-v_frag-vp9.mp4", GetParam());
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 IN_PROC_BROWSER_TEST_F(MediaTest, Navigate) { 262 IN_PROC_BROWSER_TEST_F(MediaTest, Navigate) {
262 PlayVideo("bear.webm", false); 263 PlayVideo("bear.webm", false);
263 NavigateToURL(shell(), GURL(url::kAboutBlankURL)); 264 NavigateToURL(shell(), GURL(url::kAboutBlankURL));
264 EXPECT_FALSE(shell()->web_contents()->IsCrashed()); 265 EXPECT_FALSE(shell()->web_contents()->IsCrashed());
265 } 266 }
266 267
267 INSTANTIATE_TEST_CASE_P(File, MediaTest, ::testing::Values(false)); 268 INSTANTIATE_TEST_CASE_P(File, MediaTest, ::testing::Values(false));
268 INSTANTIATE_TEST_CASE_P(Http, MediaTest, ::testing::Values(true)); 269 INSTANTIATE_TEST_CASE_P(Http, MediaTest, ::testing::Values(true));
269 270
270 } // namespace content 271 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698