DevTools: untruncate links on copy

third_party/WebKit/Source/devtools/front_end/console/ConsoleViewport.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 405 matching lines @@
     var endSelection = null;
     if (this._selectionIsBackward) {
       startSelection = this._headSelection;
       endSelection = this._anchorSelection;
     } else {
       startSelection = this._anchorSelection;
       endSelection = this._headSelection;
     }
 
     var textLines = [];
-    for (var i = startSelection.item; i <= endSelection.item; ++i)
-      textLines.push(this._providerElement(i).element().deepTextContent());
+    for (var i = startSelection.item; i <= endSelection.item; ++i) {
+      var element = this._providerElement(i).element();
+      var lineContent = element.childTextNodes().map(Components.Linkifier.untruncatedNodeText).join('');
+      textLines.push(lineContent);
+    }
 
     var endSelectionElement = this._providerElement(endSelection.item).element();
     if (endSelection.node && endSelection.node.isSelfOrDescendant(endSelectionElement)) {
       var itemTextOffset = this._textOffsetInNode(endSelectionElement, endSelection.node, endSelection.offset);
       textLines[textLines.length - 1] = textLines.peekLast().substring(0, itemTextOffset);
     }
 
     var startSelectionElement = this._providerElement(startSelection.item).element();
     if (startSelection.node && startSelection.node.isSelfOrDescendant(startSelectionElement)) {
       var itemTextOffset = this._textOffsetInNode(startSelectionElement, startSelection.node, startSelection.offset);
       textLines[0] = textLines[0].substring(itemTextOffset);
     }
 
     return textLines.join('\n');
   }
 
   /**
    * @param {!Element} itemElement
    * @param {!Node} container
    * @param {number} offset
    * @return {number}
    */
   _textOffsetInNode(itemElement, container, offset) {
     if (container.nodeType !== Node.TEXT_NODE) {
+      // If the container is not a TextNode, we may need to convert a child offset into a character offset.
       if (offset < container.childNodes.length) {
         container = /** @type {!Node} */ (container.childNodes.item(offset));
         offset = 0;
       } else {
         offset = container.textContent.length;
       }
+      // Ensure that the container does not come before the first text node.
+      if (container.textContent.length === 0 && container.nodeType !== Node.TEXT_NODE) {

[lushnikov, 2017/05/01 22:52:26]

this is unrelated to the patch - let's have this separately!

[luoe, 2017/05/01 23:03:49]

Sounds good, I've made a separate bug with the repro: crbug.com/717286

+        var nextTextNode = container.traverseNextTextNode(itemElement);
+        if (nextTextNode)
+          container = nextTextNode;
+      }
     }
+
     var chars = 0;
     var node = itemElement;
     while ((node = node.traverseNextTextNode(itemElement)) && !node.isSelfOrDescendant(container))
-      chars += node.textContent.length;
+      chars += Components.Linkifier.untruncatedNodeText(node).length;
+    // If the selection offset is at the end of a link's ellipsis, use the untruncated length as offset.
+    var untruncatedContainerLength = Components.Linkifier.untruncatedNodeText(container).length;
+    if (offset === 1 && untruncatedContainerLength > offset)
+      offset = untruncatedContainerLength;
     return chars + offset;
   }
 
   /**
    * @param {!Event} event
    */
   _onScroll(event) {
     this.refresh();
   }
 
@@ skipping 125 matching lines @@
 Console.ConsoleViewportElement.prototype = {
   willHide() {},
 
   wasShown() {},
 
   /**
    * @return {!Element}
    */
   element() {},
 };