DevTools: untruncate links on copy

third_party/WebKit/Source/devtools/front_end/platform/utilities.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 142 matching lines @@
  */
 String.prototype.collapseWhitespace = function() {
   return this.replace(/[\s\xA0]+/g, ' ');
 };
 
 /**
  * @param {number} maxLength
  * @return {string}
  */
 String.prototype.trimMiddle = function(maxLength) {
+  var indices = this.trimMiddleIndices(maxLength);
+  if (indices === null)
+    return String(this);
+  return this.substr(0, indices[0]) + '\u2026' + this.substr(indices[1], this.length - indices[1]);
+};
+
+/**
+ * @param {number} maxLength
+ * @return {?Array<number>}
+ */
+String.prototype.trimMiddleIndices = function(maxLength) {

[lushnikov, 2017/04/17 17:57:40]

Let's not introduce this method - it would be hardly ever used by anyone except
Linkifier

[luoe, 2017/04/17 22:15:07]

Done.

   if (this.length <= maxLength)
-    return String(this);
+    return null;
   var leftHalf = maxLength >> 1;
   var rightHalf = maxLength - leftHalf - 1;
   if (this.codePointAt(this.length - rightHalf - 1) >= 0x10000) {

[lushnikov, 2017/04/17 17:57:40]

Wow, something is going on here! Do you know why we need to check for
codepoints?

[luoe, 2017/04/17 22:15:07]

Emoji characters have length > 1, and we do not break them up!

     --rightHalf;
     ++leftHalf;
   }
   if (leftHalf > 0 && this.codePointAt(leftHalf - 1) >= 0x10000)
     --leftHalf;
-  return this.substr(0, leftHalf) + '\u2026' + this.substr(this.length - rightHalf, rightHalf);
+  return [leftHalf, this.length - rightHalf];
 };
 
 /**
  * @param {number} maxLength
  * @return {string}
  */
 String.prototype.trimEnd = function(maxLength) {
   if (this.length <= maxLength)
     return String(this);
   return this.substr(0, maxLength - 1) + '\u2026';
@@ skipping 1253 matching lines @@
   function windowLoaded() {
     self.removeEventListener('DOMContentLoaded', windowLoaded, false);
     callback();
   }
 
   if (document.readyState === 'complete' || document.readyState === 'interactive')
     callback();
   else
     self.addEventListener('DOMContentLoaded', windowLoaded, false);
 }