Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Issue 2644733004: Chrome OS: New window on teleported browser window should show on current desktop (Closed)
Patch Set: delete isProcessingUserEvent Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
index ec998832fa344112dff4b75ea0a815751cb25df0..2ad29fa236b83c42f5e46259484e1e55a59f5653 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
@@ -2847,20 +2847,15 @@ TEST_F(MultiProfileMultiBrowserShelfLayoutChromeLauncherControllerImplTest,
base::string16 one_menu_item1[] = { title1 };
CheckAppMenu(launcher_controller_.get(), item_browser, 1, one_menu_item1);
- // Create a browser for another user and check that it is not included in the
- // users running browser list.
Qiang(Joe) Xu 2017/02/08 00:57:36 If we create browser with profile 2, this should b
+ // Switch to another user' desktop and create a browser.
std::string user2 = "user2";
TestingProfile* profile2 = CreateMultiUserProfile(user2);
const AccountId account_id2(
multi_user_util::GetAccountIdFromProfile(profile2));
+ SwitchActiveUser(account_id2);
std::unique_ptr<Browser> browser2(
CreateBrowserAndTabWithProfile(profile2, user2, "http://test2"));
base::string16 one_menu_item2[] = { ASCIIToUTF16(user2) };
- CheckAppMenu(launcher_controller_.get(), item_browser, 1, one_menu_item1);
-
- // Switch to the other user and make sure that only that browser window gets
- // shown.
- SwitchActiveUser(account_id2);
CheckAppMenu(launcher_controller_.get(), item_browser, 1, one_menu_item2);
// Transferred browsers of other users should not show up in the list.

Powered by Google App Engine
This is Rietveld 408576698