propagate proxy auth info into the browser context.

chrome/browser/chromeos/login/existing_user_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/existing_user_controller.h"
 
 #include <memory>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 55 matching lines @@
 #include "components/signin/core/account_id/account_id.h"
 #include "components/signin/core/browser/signin_client.h"
 #include "components/user_manager/known_user.h"
 #include "components/user_manager/user_manager.h"
 #include "components/user_manager/user_names.h"
 #include "components/user_manager/user_type.h"
 #include "components/version_info/version_info.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
+#include "content/public/browser/storage_partition.h"
 #include "content/public/browser/user_metrics.h"
 #include "google_apis/gaia/gaia_auth_util.h"
 #include "google_apis/gaia/google_service_auth_error.h"
 #include "net/http/http_auth_cache.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_transaction_factory.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "ui/accessibility/ax_enums.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 23 matching lines @@
 const long int kSafeModeRestartUiDelayMs = 30000;
 
 // Makes a call to the policy subsystem to reload the policy when we detect
 // authentication change.
 void RefreshPoliciesOnUIThread() {
   if (g_browser_process->policy_service())
     g_browser_process->policy_service()->RefreshPolicies(base::Closure());
 }
 
 // Copies any authentication details that were entered in the login profile in
 // the mail profile to make sure all subsystems of Chrome can access the network

[xiyuan, 2017/01/18 23:34:08]

Could you help to update the comment since you are here?

  // .... entered in the login profile in
  // the mail profile ...

=>
  // ... entered in the login profile *to*
  // the *main* profile...

[xiaoyinh(OOO Sep 11-29), 2017/01/19 01:32:08]

Done.

 // with the provided authentication which are possibly for a proxy server.
 void TransferContextAuthenticationsOnIOThread(
     net::URLRequestContextGetter* default_profile_context_getter,
     net::URLRequestContextGetter* browser_process_context_getter) {
   net::HttpAuthCache* new_cache =
       browser_process_context_getter->GetURLRequestContext()->
       http_transaction_factory()->GetSession()->http_auth_cache();
   net::HttpAuthCache* old_cache =
       default_profile_context_getter->GetURLRequestContext()->
       http_transaction_factory()->GetSession()->http_auth_cache();
   new_cache->UpdateAllFrom(*old_cache);
+
+  // Copy the auth cache from webview's context since the proxy authentication
+  // information is saved in webview's context.
+  content::StoragePartition* signin_partition = login::GetSigninPartition();

[nharper, 2017/01/19 00:42:17]

Is there a reason for doing this here instead of replacing the
ProfileHelper::GetSigninProfile() call at
TransferContextAuthenticationsOnIOThread's callsite with this? I don't know what
the implications of that would be.

[xiaoyinh(OOO Sep 11-29), 2017/01/19 01:32:08]

Thanks for the review. I just tried the normal login flow(without proxy), and it
didn't go through this function. I'm not sure though if
TransferContextAuthenticationsOnIOThread is only used to transfer proxy auth
data. If that's the case, we probably don't need
ProfileHelper::GetSigninProfile() anymore. Initially, I just don't want  to
break existing auth flow(if any) that are propagated though
ProfileHelper::GetSigninProfile().

xiyuan@, alemate@ might know better the history and usage of GetSigninProfile()
vs GetSigninPartition();

[xiyuan, 2017/01/19 17:20:26]

The Gaia is now served in webview and GetSigninPartition() should handle that.
However, there is still a couple of things use the signin profile directly: the
iframe in ToS page and captive portal window on the login screen. It is probably
safer to copy both.

However, it is a good point to call GetSigninPartition() on the callsite of
TransferContextAuthenticationsOnIOThread.
TransferContextAuthenticationsOnIOThread as the name indicates runs on the IO
thread. And GetSigninPartition() is not thread-safe and probably does not expect
to be called on IO thread. Can we change that?

+  if (signin_partition) {
+    net::URLRequestContextGetter* webview_context =
+        signin_partition->GetURLRequestContext();
+    net::HttpAuthCache* webview_cache = webview_context->GetURLRequestContext()
+                                            ->http_transaction_factory()
+                                            ->GetSession()
+                                            ->http_auth_cache();
+    new_cache->UpdateAllFrom(*webview_cache);
+  }
+
   VLOG(1) << "Main request context populated with authentication data.";
   // Last but not least tell the policy subsystem to refresh now as it might
   // have been stuck until now too.
   content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
                                    base::Bind(&RefreshPoliciesOnUIThread));
 }
 
 // Record UMA for password login of regular user when Easy sign-in is enabled.
 void RecordPasswordLoginEvent(const UserContext& user_context) {
   EasyUnlockService* easy_unlock_service =
@@ skipping 1179 matching lines @@
   }
 
   // Otherwise, show the unrecoverable cryptohome error UI and ask user's
   // permission to collect a feedback.
   RecordPasswordChangeFlow(LOGIN_PASSWORD_CHANGE_FLOW_CRYPTOHOME_FAILURE);
   VLOG(1) << "Show unrecoverable cryptohome error dialog.";
   login_display_->ShowUnrecoverableCrypthomeErrorDialog();
 }
 
 }  // namespace chromeos