Fix memory management of VoiceSearchBarView.

ios/public/provider/chrome/browser/voice/voice_search_provider.h

Index: ios/public/provider/chrome/browser/voice/voice_search_provider.h
diff --git a/ios/public/provider/chrome/browser/voice/voice_search_provider.h b/ios/public/provider/chrome/browser/voice/voice_search_provider.h
index 05be8e6253dc4371a1503d20d9c47ed0d3dfed0b..65503a12b3025b13c1d49c531774c24476643191 100644
--- a/ios/public/provider/chrome/browser/voice/voice_search_provider.h
+++ b/ios/public/provider/chrome/browser/voice/voice_search_provider.h
@@ -40,9 +40,8 @@ class VoiceSearchProvider {
   virtual scoped_refptr<VoiceSearchController> CreateVoiceSearchController(
       ios::ChromeBrowserState* browser_state) const;
 
-  // Creates a new VoiceSearchBar.  The caller assumes ownership.
-  virtual UIView<VoiceSearchBar>* CreateVoiceSearchBar(CGRect frame) const
-      NS_RETURNS_RETAINED;
+  // Creates a new VoiceSearchBar.  The returned value is autoreleased.
+  virtual UIView<VoiceSearchBar>* BuildVoiceSearchBar(CGRect frame) const;

[rohitrao (ping after 24h), 2017/01/19 20:56:20]

Could you add a new BuildVoiceSearchBar() method while leaving the existing one
in place, then implement it downstream, then followup with a final upstream CL
to delete the old method?  It's more work, but it will also keep the autoroller
from breaking.  I'd like to avoid breaking the autoroller when possible, because
it ends up being pretty disruptive.

 
  private:
   DISALLOW_COPY_AND_ASSIGN(VoiceSearchProvider);