Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: ios/public/provider/chrome/browser/voice/voice_search_provider.h

Issue 2644703003: Fix memory management of VoiceSearchBarView. (Closed)
Patch Set: added TODO Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_PUBLIC_PROVIDER_CHROME_BROWSER_VOICE_VOICE_SEARCH_PROVIDER_H_ 5 #ifndef IOS_PUBLIC_PROVIDER_CHROME_BROWSER_VOICE_VOICE_SEARCH_PROVIDER_H_
6 #define IOS_PUBLIC_PROVIDER_CHROME_BROWSER_VOICE_VOICE_SEARCH_PROVIDER_H_ 6 #define IOS_PUBLIC_PROVIDER_CHROME_BROWSER_VOICE_VOICE_SEARCH_PROVIDER_H_
7 7
8 #import <Foundation/Foundation.h> 8 #import <Foundation/Foundation.h>
9 #import <UIKit/UIKit.h> 9 #import <UIKit/UIKit.h>
10 10
(...skipping 23 matching lines...) Expand all
34 virtual NSArray* GetAvailableLanguages() const; 34 virtual NSArray* GetAvailableLanguages() const;
35 35
36 // Returns the singleton audio session controller. 36 // Returns the singleton audio session controller.
37 virtual AudioSessionController* GetAudioSessionController() const; 37 virtual AudioSessionController* GetAudioSessionController() const;
38 38
39 // Creates a new VoiceSearchController object. 39 // Creates a new VoiceSearchController object.
40 virtual scoped_refptr<VoiceSearchController> CreateVoiceSearchController( 40 virtual scoped_refptr<VoiceSearchController> CreateVoiceSearchController(
41 ios::ChromeBrowserState* browser_state) const; 41 ios::ChromeBrowserState* browser_state) const;
42 42
43 // Creates a new VoiceSearchBar. The caller assumes ownership. 43 // Creates a new VoiceSearchBar. The caller assumes ownership.
44 // TODO(crbug.com/679719): Remove this once downstream provider implementaiton
45 // switches to BuildVoiceSearchBar().
44 virtual UIView<VoiceSearchBar>* CreateVoiceSearchBar(CGRect frame) const 46 virtual UIView<VoiceSearchBar>* CreateVoiceSearchBar(CGRect frame) const
45 NS_RETURNS_RETAINED; 47 NS_RETURNS_RETAINED;
46 48
49 // Creates a new VoiceSearchBar. Returns an autoreleased view.
50 virtual UIView<VoiceSearchBar>* BuildVoiceSearchBar(CGRect frame) const;
51
47 private: 52 private:
48 DISALLOW_COPY_AND_ASSIGN(VoiceSearchProvider); 53 DISALLOW_COPY_AND_ASSIGN(VoiceSearchProvider);
49 }; 54 };
50 55
51 #endif // IOS_PUBLIC_PROVIDER_CHROME_BROWSER_VOICE_VOICE_SEARCH_PROVIDER_H_ 56 #endif // IOS_PUBLIC_PROVIDER_CHROME_BROWSER_VOICE_VOICE_SEARCH_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698