Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: chrome/browser/ui/views/session_crashed_bubble_view.h

Issue 2644663003: Offer to open the startup pages after a crash. (Closed)
Patch Set: Missed an unsaved file :-( Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/session_crashed_bubble_view.h
diff --git a/chrome/browser/ui/views/session_crashed_bubble_view.h b/chrome/browser/ui/views/session_crashed_bubble_view.h
index 9779ce20c58f4cd5bdda6d4b4762b9a5a33900a1..031627ee43e0d431910c71813bfca680f6f13d53 100644
--- a/chrome/browser/ui/views/session_crashed_bubble_view.h
+++ b/chrome/browser/ui/views/session_crashed_bubble_view.h
@@ -62,6 +62,7 @@ class SessionCrashedBubbleView : public SessionCrashedBubble,
void OnWidgetDestroying(views::Widget* widget) override;
views::View* CreateFootnoteView() override;
bool Accept() override;
+ bool Cancel() override;
bool Close() override;
int GetDialogButtons() const override;
base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
@@ -94,6 +95,12 @@ class SessionCrashedBubbleView : public SessionCrashedBubble,
// Restore previous session after user selects so.
void RestorePreviousSession();
+ // Open startup pages after user selects so.
+ void OpenStartupPages();
+
+ // Enable UMA if the user accepted the offer.
+ void MaybeEnableUMA();
+
// Close and destroy the bubble.
void CloseBubble();
@@ -115,9 +122,9 @@ class SessionCrashedBubbleView : public SessionCrashedBubble,
// bubble shouldn't go away when the new tab page loads after a crash.
bool first_navigation_ignored_;
- // Whether or not the user chose to restore previous session. It is used to
- // collect bubble usage stats.
- bool restored_;
+ // Whether or not the user ignored with the bubble. It is used to collect
sky 2017/01/25 22:13:18 'ignored with' -> 'ignored'.
MAD 2017/01/26 03:06:58 Oups, thanks... :-)
+ // bubble usage stats.
+ bool ignored_;
DISALLOW_COPY_AND_ASSIGN(SessionCrashedBubbleView);
};
« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator.cc ('k') | chrome/browser/ui/views/session_crashed_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698