Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

Issue 2644653003: Make OffscreenCanvas animation in sync with its placeholder canvas's parent frame rate (Closed)
Patch Set: fix based on fsamuel's feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
diff --git a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
index 6f10cc7993f666a5d33f9ccb9a6ea3e798b8d238..dd44d168cdb7dca55c8e26f4116467b178ed4411 100644
--- a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
+++ b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
@@ -32,6 +32,7 @@ class PLATFORM_EXPORT OffscreenCanvasFrameDispatcherImpl final
// OffscreenCanvasFrameDispatcher implementation.
~OffscreenCanvasFrameDispatcherImpl() final;
+ void setNeedsBeginFrame(bool doesNeedBeginFrame);
Justin Novosad 2017/01/19 18:06:49 Missing "final" (I am surprised this compiles) No
xlai (Olivia) 2017/01/19 19:14:34 Done.
void dispatchFrame(RefPtr<StaticBitmapImage>,
double commitStartTime,
bool isWebGLSoftwareRendering = false) final;
@@ -56,15 +57,13 @@ class PLATFORM_EXPORT OffscreenCanvasFrameDispatcherImpl final
private:
// Surface-related
cc::SurfaceIdAllocator m_surfaceIdAllocator;
- void scheduleSyntheticBeginFrame(); // To be removed (crbug.com/674744)
-
- TaskHandle m_syntheticBeginFrameTask; // To be removed (crbug.com/674744)
const cc::FrameSinkId m_frameSinkId;
cc::LocalFrameId m_currentLocalFrameId;
int m_width;
int m_height;
bool m_changeSizeForNextCommit;
+ bool m_needsBeginFrame;
unsigned m_nextResourceId;
HashMap<unsigned, RefPtr<StaticBitmapImage>> m_cachedImages;

Powered by Google App Engine
This is Rietveld 408576698