Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Unified Diff: content/browser/renderer_host/offscreen_canvas_surface_manager.h

Issue 2644653003: Make OffscreenCanvas animation in sync with its placeholder canvas's parent frame rate (Closed)
Patch Set: fix based on fsamuel's feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/offscreen_canvas_surface_manager.h
diff --git a/content/browser/renderer_host/offscreen_canvas_surface_manager.h b/content/browser/renderer_host/offscreen_canvas_surface_manager.h
index e53cea7037c5e09512523121927d78c2c467f543..f052507ea042aff86127196869a73447b4876682 100644
--- a/content/browser/renderer_host/offscreen_canvas_surface_manager.h
+++ b/content/browser/renderer_host/offscreen_canvas_surface_manager.h
@@ -20,10 +20,16 @@ class CONTENT_EXPORT OffscreenCanvasSurfaceManager
static OffscreenCanvasSurfaceManager* GetInstance();
- void RegisterOffscreenCanvasSurfaceInstance(cc::FrameSinkId,
+ // Registration of the frame sink with the given frame sink id to its parent
+ // frame sink (if it has one), so that parent frame is able to send signals
+ // to it on begin frame.
+ void RegisterFrameSinkToParent(const cc::FrameSinkId&);
Fady Samuel 2017/01/19 17:10:54 chromium style nit: give the param a name: e.g. c
xlai (Olivia) 2017/01/19 19:14:34 Done for here and elsewhere.
+ void UnregisterFrameSinkFromParent(const cc::FrameSinkId&);
Fady Samuel 2017/01/19 17:10:53 chromium style nit: give the param a name: e.g. c
+
+ void RegisterOffscreenCanvasSurfaceInstance(const cc::FrameSinkId&,
Fady Samuel 2017/01/19 17:10:54 chromium style nit: give the param a name: e.g. c
OffscreenCanvasSurfaceImpl*);
Fady Samuel 2017/01/19 17:10:54 chromium style nit: give the param a name: e.g Of
- void UnregisterOffscreenCanvasSurfaceInstance(cc::FrameSinkId);
- OffscreenCanvasSurfaceImpl* GetSurfaceInstance(cc::FrameSinkId);
+ void UnregisterOffscreenCanvasSurfaceInstance(const cc::FrameSinkId&);
Fady Samuel 2017/01/19 17:10:54 const cc::FrameSinkId& frame_sink_id
+ OffscreenCanvasSurfaceImpl* GetSurfaceInstance(const cc::FrameSinkId&);
Fady Samuel 2017/01/19 17:10:53 const cc::FrameSinkId& frame_sink_id
private:
friend class OffscreenCanvasSurfaceManagerTest;

Powered by Google App Engine
This is Rietveld 408576698