Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: src/builtins/s390/builtins-s390.cc

Issue 2644643011: [builtins] Don't put doubles on the stack in ConstructWithSpread. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/ppc/builtins-ppc.cc ('k') | src/builtins/x64/builtins-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 2854 matching lines...) Expand 10 before | Expand all | Expand 10 after
2865 ContextMemOperand( 2865 ContextMemOperand(
2866 scratch2, Context::INITIAL_ARRAY_ITERATOR_PROTOTYPE_MAP_INDEX)); 2866 scratch2, Context::INITIAL_ARRAY_ITERATOR_PROTOTYPE_MAP_INDEX));
2867 __ CmpP(scratch, scratch2); 2867 __ CmpP(scratch, scratch2);
2868 __ bne(&runtime_call); 2868 __ bne(&runtime_call);
2869 2869
2870 // For FastPacked kinds, iteration will have the same effect as simply 2870 // For FastPacked kinds, iteration will have the same effect as simply
2871 // accessing each property in order. 2871 // accessing each property in order.
2872 Label no_protector_check; 2872 Label no_protector_check;
2873 __ LoadP(scratch, FieldMemOperand(spread_map, Map::kBitField2Offset)); 2873 __ LoadP(scratch, FieldMemOperand(spread_map, Map::kBitField2Offset));
2874 __ DecodeField<Map::ElementsKindBits>(scratch); 2874 __ DecodeField<Map::ElementsKindBits>(scratch);
2875 __ CmpP(scratch, Operand(LAST_FAST_ELEMENTS_KIND)); 2875 __ CmpP(scratch, Operand(FAST_HOLEY_ELEMENTS));
2876 __ bgt(&runtime_call); 2876 __ bgt(&runtime_call);
2877 // For non-FastHoley kinds, we can skip the protector check. 2877 // For non-FastHoley kinds, we can skip the protector check.
2878 __ CmpP(scratch, Operand(FAST_SMI_ELEMENTS)); 2878 __ CmpP(scratch, Operand(FAST_SMI_ELEMENTS));
2879 __ beq(&no_protector_check); 2879 __ beq(&no_protector_check);
2880 __ CmpP(scratch, Operand(FAST_ELEMENTS)); 2880 __ CmpP(scratch, Operand(FAST_ELEMENTS));
2881 __ beq(&no_protector_check); 2881 __ beq(&no_protector_check);
2882 __ CmpP(scratch, Operand(FAST_DOUBLE_ELEMENTS));
2883 __ beq(&no_protector_check);
2884 // Check the ArrayProtector cell. 2882 // Check the ArrayProtector cell.
2885 __ LoadRoot(scratch, Heap::kArrayProtectorRootIndex); 2883 __ LoadRoot(scratch, Heap::kArrayProtectorRootIndex);
2886 __ LoadP(scratch, FieldMemOperand(scratch, PropertyCell::kValueOffset)); 2884 __ LoadP(scratch, FieldMemOperand(scratch, PropertyCell::kValueOffset));
2887 __ CmpSmiLiteral(scratch, Smi::FromInt(Isolate::kProtectorValid), r0); 2885 __ CmpSmiLiteral(scratch, Smi::FromInt(Isolate::kProtectorValid), r0);
2888 __ bne(&runtime_call); 2886 __ bne(&runtime_call);
2889 2887
2890 __ bind(&no_protector_check); 2888 __ bind(&no_protector_check);
2891 // Load the FixedArray backing store. 2889 // Load the FixedArray backing store.
2892 __ LoadP(spread, FieldMemOperand(spread, JSArray::kElementsOffset)); 2890 __ LoadP(spread, FieldMemOperand(spread, JSArray::kElementsOffset));
2893 __ b(&push_args); 2891 __ b(&push_args);
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
3120 __ bkpt(0); 3118 __ bkpt(0);
3121 } 3119 }
3122 } 3120 }
3123 3121
3124 #undef __ 3122 #undef __
3125 3123
3126 } // namespace internal 3124 } // namespace internal
3127 } // namespace v8 3125 } // namespace v8
3128 3126
3129 #endif // V8_TARGET_ARCH_S390 3127 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/builtins/ppc/builtins-ppc.cc ('k') | src/builtins/x64/builtins-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698