Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 264463003: remove unnessary overrides, as base class now does this for shaders (Closed)

Created:
6 years, 7 months ago by reed1
Modified:
6 years, 7 months ago
Reviewers:
scroggo, f(malita), reed2
CC:
chromium-reviews
Visibility:
Public.

Description

remove unnessary overrides, as base class now does this for shaders win_chromium_rel failure unrelated to this CL NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267724

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M skia/ext/pixel_ref_utils_unittest.cc View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
reed1
6 years, 7 months ago (2014-04-30 18:45:21 UTC) #1
scroggo
On 2014/04/30 18:45:21, reed1 wrote: As noted in https://codereview.chromium.org/262703002/, if contextSize returns 0, this may ...
6 years, 7 months ago (2014-04-30 21:39:26 UTC) #2
scroggo
On 2014/04/30 21:39:26, scroggo wrote: > On 2014/04/30 18:45:21, reed1 wrote: > > As noted ...
6 years, 7 months ago (2014-04-30 21:39:34 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-01 19:03:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/264463003/20001
6 years, 7 months ago (2014-05-01 19:04:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 19:04:17 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-01 19:04:18 UTC) #7
f(malita)
lgtm
6 years, 7 months ago (2014-05-01 19:05:22 UTC) #8
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-01 19:05:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/264463003/20001
6 years, 7 months ago (2014-05-01 19:06:01 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 19:57:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-01 19:57:27 UTC) #12
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-01 20:13:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/264463003/20001
6 years, 7 months ago (2014-05-01 20:14:24 UTC) #14
reed2
The CQ bit was unchecked by reed@chromium.org
6 years, 7 months ago (2014-05-02 01:58:44 UTC) #15
reed2
The CQ bit was checked by reed@chromium.org
6 years, 7 months ago (2014-05-02 01:58:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/264463003/20001
6 years, 7 months ago (2014-05-02 02:00:32 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 02:01:36 UTC) #18
Message was sent while issue was closed.
Change committed as 267724

Powered by Google App Engine
This is Rietveld 408576698