|
|
Created:
6 years, 7 months ago by reed1 Modified:
6 years, 7 months ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
Descriptionremove unnessary overrides, as base class now does this for shaders
win_chromium_rel failure unrelated to this CL
NOTRY=True
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267724
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 18 (0 generated)
On 2014/04/30 18:45:21, reed1 wrote: As noted in https://codereview.chromium.org/262703002/, if contextSize returns 0, this may result in an assert (but then again, it may not; I don't know this test well).
On 2014/04/30 21:39:26, scroggo wrote: > On 2014/04/30 18:45:21, reed1 wrote: > > As noted in https://codereview.chromium.org/262703002/, if contextSize returns > 0, this may result in an assert (but then again, it may not; I don't know this > test well). lgtm though
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/264463003/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/264463003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/264463003/20001
The CQ bit was unchecked by reed@chromium.org
The CQ bit was checked by reed@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/264463003/20001
Message was sent while issue was closed.
Change committed as 267724 |