Fix bugs in the display notification

ash/system/chromeos/screen_layout_observer_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/chromeos/screen_layout_observer.h"
 
 #include "ash/common/system/chromeos/devicetype_utils.h"
 #include "ash/common/system/tray/system_tray.h"
 #include "ash/common/test/test_system_tray_delegate.h"
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "grit/ash_strings.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/display/display.h"
+#include "ui/display/display_layout_builder.h"
 #include "ui/display/manager/display_manager.h"
 #include "ui/message_center/message_center.h"
 #include "ui/message_center/notification.h"
 #include "ui/message_center/notification_list.h"
 #include "ui/views/controls/label.h"
 
 namespace ash {
 
 class ScreenLayoutObserverTest : public test::AshTestBase {
  public:
@@ skipping 57 matching lines @@
 
 base::string16 ScreenLayoutObserverTest::GetMirroringDisplayName() {
   return base::UTF8ToUTF16(display_manager()->GetDisplayNameForId(
       display_manager()->mirroring_display_id()));
 }
 
 const message_center::Notification*
 ScreenLayoutObserverTest::GetDisplayNotification() const {
   const message_center::NotificationList::Notifications notifications =
       message_center::MessageCenter::Get()->GetVisibleNotifications();
-  for (message_center::NotificationList::Notifications::const_iterator iter =
-           notifications.begin();
-       iter != notifications.end(); ++iter) {
-    if ((*iter)->id() == ScreenLayoutObserver::kNotificationId)
-      return *iter;
+  for (const auto& notification : notifications) {
+    if (notification->id() == ScreenLayoutObserver::kNotificationId)
+      return notification;
   }
 
-  return NULL;
+  return nullptr;
 }
 
 TEST_F(ScreenLayoutObserverTest, DisplayNotifications) {
   Shell::GetInstance()
       ->screen_layout_observer()
       ->set_show_notifications_for_testing(true);
 
   UpdateDisplay("400x400");
   display::Display::SetInternalDisplayId(display_manager()->first_display_id());
   EXPECT_TRUE(GetDisplayNotificationText().empty());
@@ skipping 107 matching lines @@
             GetDisplayNotificationText());
 
   // OnDisplayConfigurationChanged() may be called more than once for a single
   // update display in case of primary is swapped or recovered from dock mode.
   // Should not remove the notification in such case.
   GetScreenLayoutObserver()->OnDisplayConfigurationChanged();
   EXPECT_EQ(l10n_util::GetStringUTF16(
                 IDS_ASH_STATUS_TRAY_DISPLAY_EXTENDED_NO_INTERNAL),
             GetDisplayNotificationText());
 
-  // Back to the single display. It SHOULD remove the notification since the
-  // information is stale.
+  // Back to the single display. It should show that a display was removed.
   UpdateDisplay("400x400");
-  EXPECT_TRUE(GetDisplayNotificationText().empty());
+  EXPECT_TRUE(base::StartsWith(
+      GetDisplayNotificationText(),
+      l10n_util::GetStringFUTF16(IDS_ASH_STATUS_TRAY_DISPLAY_REMOVED,
+                                 base::UTF8ToUTF16("")),
+      base::CompareCase::SENSITIVE));
 }
 
 // Verify the notification message content when one of the 2 displays that
 // connected to the device is rotated.
 TEST_F(ScreenLayoutObserverTest, UpdateAfterSuppressDisplayNotification) {
   UpdateDisplay("400x400,200x200");
 
   Shell::GetInstance()
       ->screen_layout_observer()
       ->set_show_notifications_for_testing(true);
@@ skipping 20 matching lines @@
   EXPECT_TRUE(GetDisplayNotificationText().empty());
   EXPECT_TRUE(GetDisplayNotificationAdditionalText().empty());
 
   // Reset the overscan.
   Shell::GetInstance()->display_manager()->SetOverscanInsets(
       display_manager()->GetSecondaryDisplay().id(), gfx::Insets());
   EXPECT_TRUE(GetDisplayNotificationText().empty());
   EXPECT_TRUE(GetDisplayNotificationAdditionalText().empty());
 }
 
+// Tests that exiting mirror mode by closing the lid shows the correct "docked
+// mode" message.
+TEST_F(ScreenLayoutObserverTest, ExitMirrorModeBecauseOfDockedModeMessage) {
+  Shell::GetInstance()
+      ->screen_layout_observer()
+      ->set_show_notifications_for_testing(true);
+  UpdateDisplay("400x400,200x200");
+  display::Display::SetInternalDisplayId(
+      display_manager()->GetSecondaryDisplay().id());
+
+  // Mirroring.
+  display_manager()->SetSoftwareMirroring(true);
+  UpdateDisplay("400x400,200x200");
+  EXPECT_EQ(l10n_util::GetStringFUTF16(IDS_ASH_STATUS_TRAY_DISPLAY_MIRRORING,
+                                       GetMirroringDisplayName()),
+            GetDisplayNotificationText());
+
+  // Docked.
+  CloseNotification();
+  display_manager()->SetSoftwareMirroring(false);
+  display::Display::SetInternalDisplayId(display_manager()->first_display_id());
+  UpdateDisplay("200x200");
+  EXPECT_EQ(l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_DISPLAY_DOCKED),
+            GetDisplayNotificationText());
+  EXPECT_EQ(ash::SubstituteChromeOSDeviceType(
+                IDS_ASH_STATUS_TRAY_DISPLAY_DOCKED_DESCRIPTION),
+            GetDisplayNotificationAdditionalText());
+}
+
+// Tests that exiting mirror mode because of adding a third display shows the
+// correct "3+ displays mirror mode is not supported" message.
+TEST_F(ScreenLayoutObserverTest, ExitMirrorModeBecauseOfThirdDisplayMessage) {
+  Shell::GetInstance()
+      ->screen_layout_observer()
+      ->set_show_notifications_for_testing(true);
+  UpdateDisplay("400x400,200x200");
+  display::Display::SetInternalDisplayId(
+      display_manager()->GetSecondaryDisplay().id());
+
+  // Mirroring.
+  display_manager()->SetSoftwareMirroring(true);
+  UpdateDisplay("400x400,200x200");
+  EXPECT_EQ(l10n_util::GetStringFUTF16(IDS_ASH_STATUS_TRAY_DISPLAY_MIRRORING,
+                                       GetMirroringDisplayName()),
+            GetDisplayNotificationText());
+
+  // Adding a third display. Mirror mode for 3+ displays is not supported.
+  CloseNotification();
+  display_manager()->SetSoftwareMirroring(false);
+  UpdateDisplay("400x400,200x200,100x100");
+  EXPECT_EQ(l10n_util::GetStringUTF16(IDS_ASH_DISPLAY_MIRRORING_NOT_SUPPORTED),
+            GetDisplayNotificationText());
+}
+
+// Special case: tests that exiting mirror mode by removing a display shows no
+// notifications.
+TEST_F(ScreenLayoutObserverTest,
+       ExitMirrorModeNoInternalDisplayBecauseOfDisplayRemovedMessage) {
+  Shell::GetInstance()
+      ->screen_layout_observer()
+      ->set_show_notifications_for_testing(true);
+  UpdateDisplay("400x400,200x200");
+  display::Display::SetInternalDisplayId(
+      display_manager()->GetSecondaryDisplay().id());
+
+  // Mirroring.
+  display_manager()->SetSoftwareMirroring(true);
+  UpdateDisplay("400x400,200x200");
+  EXPECT_EQ(l10n_util::GetStringFUTF16(IDS_ASH_STATUS_TRAY_DISPLAY_MIRRORING,
+                                       GetMirroringDisplayName()),
+            GetDisplayNotificationText());
+
+  // Removing one of the displays. We show no notification.
+  CloseNotification();
+  display_manager()->SetSoftwareMirroring(false);
+  UpdateDisplay("400x400");
+  EXPECT_TRUE(GetDisplayNotificationText().empty());
+}
+
+// Tests notification messages shown when adding and removing displays in
+// extended mode.
+TEST_F(ScreenLayoutObserverTest, AddingRemovingDisplayExtendedModeMessage) {
+  Shell::GetInstance()
+      ->screen_layout_observer()
+      ->set_show_notifications_for_testing(true);
+  UpdateDisplay("400x400");
+  EXPECT_TRUE(GetDisplayNotificationText().empty());
+
+  // Adding a display in extended mode.
+  UpdateDisplay("400x400,200x200");
+  EXPECT_EQ(l10n_util::GetStringUTF16(
+                IDS_ASH_STATUS_TRAY_DISPLAY_EXTENDED_NO_INTERNAL),
+            GetDisplayNotificationText());
+
+  // Removing a display.
+  CloseNotification();
+  UpdateDisplay("400x400");
+  EXPECT_TRUE(base::StartsWith(
+      GetDisplayNotificationText(),
+      l10n_util::GetStringFUTF16(IDS_ASH_STATUS_TRAY_DISPLAY_REMOVED,
+                                 base::UTF8ToUTF16("")),
+      base::CompareCase::SENSITIVE));
+}
+
+// Tests notification messages shown when entering and exiting unified desktop
+// mode.
+TEST_F(ScreenLayoutObserverTest, EnteringExitingUnifiedModeMessage) {
+  Shell::GetInstance()
+      ->screen_layout_observer()
+      ->set_show_notifications_for_testing(true);
+  UpdateDisplay("400x400");
+  EXPECT_TRUE(GetDisplayNotificationText().empty());
+
+  // Adding a display in extended mode.
+  UpdateDisplay("400x400,200x200");
+  EXPECT_EQ(l10n_util::GetStringUTF16(
+                IDS_ASH_STATUS_TRAY_DISPLAY_EXTENDED_NO_INTERNAL),
+            GetDisplayNotificationText());
+
+  // Enter unified mode.
+  display_manager()->SetUnifiedDesktopEnabled(true);
+  EXPECT_EQ(l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_DISPLAY_UNIFIED),
+            GetDisplayNotificationText());
+
+  // Exit unified mode.
+  display_manager()->SetUnifiedDesktopEnabled(false);
+  EXPECT_EQ(
+      l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_DISPLAY_UNIFIED_EXITING),
+      GetDisplayNotificationText());
+
+  // Enter unified mode again and exit via closing the lid. The message "Exiting
+  // unified mode" should be shown.
+  display_manager()->SetUnifiedDesktopEnabled(true);
+  EXPECT_EQ(l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_DISPLAY_UNIFIED),
+            GetDisplayNotificationText());
+
+  // Close the lid.
+  display::Display::SetInternalDisplayId(display_manager()->first_display_id());
+  UpdateDisplay("200x200");
+  display_manager()->SetUnifiedDesktopEnabled(false);
+  EXPECT_EQ(
+      l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_DISPLAY_UNIFIED_EXITING),
+      GetDisplayNotificationText());
+}
+
+// Special case: Tests notification messages shown when entering docked mode
+// by closing the lid and the internal display is the secondary display.
+TEST_F(ScreenLayoutObserverTest, DockedModeWithExternalPrimaryDisplayMessage) {
+  Shell::GetInstance()
+      ->screen_layout_observer()
+      ->set_show_notifications_for_testing(true);
+  UpdateDisplay("400x400,200x200");
+  EXPECT_EQ(l10n_util::GetStringUTF16(
+                IDS_ASH_STATUS_TRAY_DISPLAY_EXTENDED_NO_INTERNAL),
+            GetDisplayNotificationText());
+  CloseNotification();
+
+  const int64_t primary_id = display_manager()->GetDisplayAt(0).id();
+  const int64_t internal_secondary_id = display_manager()->GetDisplayAt(1).id();
+  display::Display::SetInternalDisplayId(internal_secondary_id);
+  display::DisplayLayoutBuilder builder(primary_id);
+  builder.AddDisplayPlacement(internal_secondary_id, primary_id,
+                              display::DisplayPlacement::LEFT, 0);
+  display_manager()->SetLayoutForCurrentDisplays(builder.Build());
+  EXPECT_TRUE(GetDisplayNotificationText().empty());
+
+  // Close the lid and expect we show the docked mode message.
+  UpdateDisplay("400x400");
+  EXPECT_EQ(l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_DISPLAY_DOCKED),
+            GetDisplayNotificationText());
+  EXPECT_EQ(ash::SubstituteChromeOSDeviceType(
+                IDS_ASH_STATUS_TRAY_DISPLAY_DOCKED_DESCRIPTION),
+            GetDisplayNotificationAdditionalText());
+}
+
 }  // namespace ash