Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: tools/test.py

Issue 2644593002: Buildbot: Change --copy-crashdumps to do the actual archiving to CloudStorage. (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 2 # Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
3 # for details. All rights reserved. Use of this source code is governed by a 3 # for details. All rights reserved. Use of this source code is governed by a
4 # BSD-style license that can be found in the LICENSE file. 4 # BSD-style license that can be found in the LICENSE file.
5 5
6 import os 6 import os
7 import string 7 import string
8 import subprocess 8 import subprocess
9 import sys 9 import sys
10 10
(...skipping 10 matching lines...) Expand all
21 21
22 # The testing script potentially needs the android platform tools in PATH so 22 # The testing script potentially needs the android platform tools in PATH so
23 # we do that in ./tools/test.py (a similar logic exists in ./tools/build.py). 23 # we do that in ./tools/test.py (a similar logic exists in ./tools/build.py).
24 android_platform_tools = os.path.normpath(os.path.join( 24 android_platform_tools = os.path.normpath(os.path.join(
25 tools_dir, 25 tools_dir,
26 '../third_party/android_tools/sdk/platform-tools')) 26 '../third_party/android_tools/sdk/platform-tools'))
27 if os.path.isdir(android_platform_tools): 27 if os.path.isdir(android_platform_tools):
28 os.environ['PATH'] = '%s%s%s' % ( 28 os.environ['PATH'] = '%s%s%s' % (
29 os.environ['PATH'], os.pathsep, android_platform_tools) 29 os.environ['PATH'], os.pathsep, android_platform_tools)
30 30
31 exit_code = subprocess.call(command) 31 with utils.CoreDumpArchiver(args):
32 exit_code = subprocess.call(command)
33
32 utils.DiagnoseExitCode(exit_code, command) 34 utils.DiagnoseExitCode(exit_code, command)
33 return exit_code 35 return exit_code
34 36
35 37
36 if __name__ == '__main__': 38 if __name__ == '__main__':
37 sys.exit(Main()) 39 sys.exit(Main())
OLDNEW
« no previous file with comments | « no previous file | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698