Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

Issue 2644553002: Refactor TimeDomain::MaybeAdvanceTime in preparation for DoWork deduping (Closed)
Patch Set: Rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
index 7a5e35eb810547cb9c3596ded826f9999eb7ebad..413c64a553c04b11fd40df936a929ca1193fec46 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
@@ -44,7 +44,10 @@ class MockTimeDomain : public TimeDomain {
void AsValueIntoInternal(
base::trace_event::TracedValue* state) const override {}
- bool MaybeAdvanceTime() override { return false; }
+ base::Optional<base::TimeDelta> DelayTillNextTask(
+ LazyNow* lazy_now) override {
+ return base::Optional<base::TimeDelta>();
+ }
const char* GetName() const override { return "Test"; }
void OnRegisterWithTaskQueueManager(
TaskQueueManager* task_queue_manager) override {}
@@ -203,13 +206,13 @@ TEST_F(TimeDomainTest, UpdateWorkQueues) {
EXPECT_EQ(delayed_runtime, next_run_time);
LazyNow lazy_now = time_domain_->CreateLazyNow();
- time_domain_->UpdateWorkQueues(lazy_now);
+ time_domain_->UpdateWorkQueues(&lazy_now);
ASSERT_TRUE(time_domain_->NextScheduledRunTime(&next_run_time));
EXPECT_EQ(delayed_runtime, next_run_time);
time_domain_->SetNow(delayed_runtime);
lazy_now = time_domain_->CreateLazyNow();
- time_domain_->UpdateWorkQueues(lazy_now);
+ time_domain_->UpdateWorkQueues(&lazy_now);
ASSERT_FALSE(time_domain_->NextScheduledRunTime(&next_run_time));
}

Powered by Google App Engine
This is Rietveld 408576698