Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: appengine/findit/util_scripts/crash_queries/delta_test/delta_test.py

Issue 2644543006: [Culprit-Finder] Add generator cache decorator. (Closed)
Patch Set: Rebase and fix nits. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/util_scripts/crash_queries/delta_test/delta_test.py
diff --git a/appengine/findit/util_scripts/crash_queries/delta_test/delta_test.py b/appengine/findit/util_scripts/crash_queries/delta_test/delta_test.py
index b166f2332596709fa468f521eee73d7ac32f7e2b..cf1220d2263c04746ed7ec311d936f0e1ef1e7b2 100644
--- a/appengine/findit/util_scripts/crash_queries/delta_test/delta_test.py
+++ b/appengine/findit/util_scripts/crash_queries/delta_test/delta_test.py
@@ -200,7 +200,7 @@ def DeltaEvaluator(git_hash1, git_hash2,
app_id (str): Appengine app id to query.
batch_size (int): Size of a batch that can be queried at one time.
property_values (dict): Property values to query.
- batch_size (int): The size of crashes that can be queried at one time.
+ batch_size (int): The size of crashes that can be queried at one time.
verbose (bool): If True, print all the findit results.
Return:
(deltas, crash_count).
@@ -214,14 +214,13 @@ def DeltaEvaluator(git_hash1, git_hash2,
crash_count = 0
# Iterate batches of crash informations.
for index, crashes in enumerate(
- crash_iterator.IterateCrashes(client_id, app_id,
- fields=CRASH_FIELDS,
- property_values=property_values,
- start_date=start_date,
- end_date=end_date,
- batch_size=batch_size,
- batch_run=True)):
-
+ crash_iterator.CachedCrashIterator(client_id, app_id,
+ fields=CRASH_FIELDS,
+ property_values=property_values,
+ start_date=start_date,
+ end_date=end_date,
+ batch_size=batch_size,
+ batch_run=True)):
results = []
for git_hash in [git_hash1, git_hash2]:
result_path = os.path.join(
« no previous file with comments | « appengine/findit/util_scripts/crash_queries/crash_iterator.py ('k') | appengine/findit/util_scripts/script_util.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698