Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4441)

Unified Diff: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc

Issue 2644543002: Add counter for number of page loads where doc.write blocking triggers. (Closed)
Patch Set: switch to UMA_HISTOGRAM_BOOLEAN. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
index 4b9c2640a6914e212471e0a592b8df3e6d28f0b9..52726c58e27b6f97733ecab056154d8c50e01398 100644
--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
@@ -89,6 +89,8 @@ TEST_F(DocumentWritePageLoadMetricsObserverTest, PossibleBlock) {
NavigateAndCommit(GURL("https://www.google.com"));
SimulateTimingAndMetadataUpdate(timing, metadata);
+ histogram_tester().ExpectTotalCount(internal::kHistogramDocWriteBlockCount,
+ 1);
histogram_tester().ExpectTotalCount(
internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 1);
histogram_tester().ExpectBucketCount(
@@ -134,6 +136,9 @@ TEST_F(DocumentWritePageLoadMetricsObserverTest, PossibleBlockReload) {
SimulateTimingAndMetadataUpdate(timing, metadata);
histogram_tester().ExpectTotalCount(
internal::kHistogramDocWriteBlockReloadCount, 2);
+
+ histogram_tester().ExpectTotalCount(internal::kHistogramDocWriteBlockCount,
+ 0);
}
TEST_F(DocumentWritePageLoadMetricsObserverTest, NoPossibleBlock) {

Powered by Google App Engine
This is Rietveld 408576698