Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2644533002: Mostly use entities in use.dart (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixes #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -194 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/entities.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +2 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_parser.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 16 chunks +71 lines, -58 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 11 chunks +27 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 chunk +2 lines, -8 lines 2 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +8 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 7 chunks +24 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 3 chunks +10 lines, -4 lines 1 comment Download
M pkg/compiler/lib/src/universe/use.dart View 1 23 chunks +48 lines, -30 lines 2 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-18 13:13:25 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2644533002/diff/20001/pkg/compiler/lib/src/resolution/typedefs.dart File pkg/compiler/lib/src/resolution/typedefs.dart (right): https://codereview.chromium.org/2644533002/diff/20001/pkg/compiler/lib/src/resolution/typedefs.dart#newcode32 pkg/compiler/lib/src/resolution/typedefs.dart:32: FunctionSignature signature = SignatureResolver.analyze(resolution, scope, new version of ...
3 years, 11 months ago (2017-01-18 19:27:53 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 916a8855d4ec67a0fbb1aec0493b74e1cb84d265 (presubmit successful).
3 years, 11 months ago (2017-01-19 12:20:47 UTC) #5
Johnni Winther
3 years, 11 months ago (2017-01-19 12:20:57 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2644533002/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/typedefs.dart (right):

https://codereview.chromium.org/2644533002/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/typedefs.dart:32: FunctionSignature signature =
SignatureResolver.analyze(resolution, scope,
On 2017/01/18 19:27:53, Siggi Cherem (dart-lang) wrote:
> new version of dartfmt keeps changing this around? should we do a global
dartfmt
> step to clean up?

If it keeps popping up.

https://codereview.chromium.org/2644533002/diff/20001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/use.dart (right):

https://codereview.chromium.org/2644533002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/use.dart:27: Entity,
On 2017/01/18 19:27:53, Siggi Cherem (dart-lang) wrote:
> should we move Entity to entities.dart?

Soon-ish.

Powered by Google App Engine
This is Rietveld 408576698