Issue 2644513002: Revert "Fix some crashes in dartk."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2644513002: Revert "Fix some crashes in dartk." (Closed)

Created:
3 years, 11 months ago by asgerf

Modified:
3 years, 11 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Fix some crashes in dartk." This reverts commit d01bd88152b2d30d6a06d1379e41e1280d094dab. Some status file updates were missing for precompiled mode. BUG= Committed: https://github.com/dart-lang/sdk/commit/6272e23d35ba04b339a6748eaf08d4b1dfc5e788

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -73 lines)			Patch
M	pkg/kernel/lib/analyzer/ast_from_analyzer.dart	View	4 chunks	+7 lines, -28 lines	0 comments	Download
M	pkg/kernel/lib/analyzer/loader.dart	View	4 chunks	+6 lines, -36 lines	0 comments	Download
M	tests/co19/co19-kernel.status	View	5 chunks	+9 lines, -3 lines	0 comments	Download
M	tests/language/language_kernel.status	View	8 chunks	+9 lines, -6 lines	0 comments	Download

Total messages: 4 (2 generated)

asgerf

3 years, 11 months ago (2017-01-18 11:21:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6272e23d35ba04b339a6748eaf08d4b1dfc5e788 (presubmit successful).