Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: tools/foozzie/v8_suppressions.py

Issue 2644503002: [foozzie] Fix suppressions and add one for crbug.com/681241 (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/foozzie/v8_suppressions.py
diff --git a/tools/foozzie/v8_suppressions.py b/tools/foozzie/v8_suppressions.py
index 3fd750a33b7de5ae67b7590ee31d0362d66076c0..5fd3440faa64c2123deb1097d0d46da8aa9f4e85 100644
--- a/tools/foozzie/v8_suppressions.py
+++ b/tools/foozzie/v8_suppressions.py
@@ -33,28 +33,36 @@ MAX_LINE_LENGTH = 512
# For ignoring lines before carets and to ignore caret positions.
CARET_RE = re.compile(r'^\s*\^\s*$')
-# Ignore by original source files. Map from bug->relative file paths in V8,
-# e.g. '/v8/test/mjsunit/d8-performance-now.js' including /v8/. A test will
+# Ignore by original source files. Map from bug->list of relative file paths in
+# V8, e.g. '/v8/test/mjsunit/d8-performance-now.js' including /v8/. A test will
# be suppressed if one of the files below was used to mutate the test.
IGNORE_SOURCES = {
# This contains a usage of f.arguments that often fires.
- 'crbug.com/662424': '/v8/test/mjsunit/regress/regress-2989.js',
+ 'crbug.com/662424': ['/v8/test/mjsunit/regress/regress-2989.js'],
# crbug.com/681088
- 'crbug.com/681088': '/v8/test/mjsunit/asm/asm-validation.js',
- 'crbug.com/681088': '/v8/test/mjsunit/asm/b5528-comma.js',
- 'crbug.com/681088': '/v8/test/mjsunit/asm/pointer-masking.js',
- 'crbug.com/681088': '/v8/test/mjsunit/compiler/regress-443744.js',
- 'crbug.com/681088': '/v8/test/mjsunit/regress/regress-599719.js',
- 'crbug.com/681088': '/v8/test/mjsunit/regress/wasm/regression-647649.js',
- 'crbug.com/681088': '/v8/test/mjsunit/wasm/asm-wasm.js',
- 'crbug.com/681088': '/v8/test/mjsunit/wasm/asm-wasm-deopt.js',
- 'crbug.com/681088': '/v8/test/mjsunit/wasm/asm-wasm-heap.js',
- 'crbug.com/681088': '/v8/test/mjsunit/wasm/asm-wasm-literals.js',
- 'crbug.com/681088': '/v8/test/mjsunit/wasm/asm-wasm-stack.js',
+ 'crbug.com/681088': [
+ '/v8/test/mjsunit/asm/asm-validation.js',
+ '/v8/test/mjsunit/asm/b5528-comma.js',
+ '/v8/test/mjsunit/asm/pointer-masking.js',
+ '/v8/test/mjsunit/compiler/regress-443744.js',
+ '/v8/test/mjsunit/regress/regress-599719.js',
+ '/v8/test/mjsunit/regress/wasm/regression-647649.js',
+ '/v8/test/mjsunit/wasm/asm-wasm.js',
+ '/v8/test/mjsunit/wasm/asm-wasm-deopt.js',
+ '/v8/test/mjsunit/wasm/asm-wasm-heap.js',
+ '/v8/test/mjsunit/wasm/asm-wasm-literals.js',
+ '/v8/test/mjsunit/wasm/asm-wasm-stack.js',
+ ],
# crbug.com/681236
- 'crbug.com/681236': '/v8/test/mjsunit/wasm/asm-wasm-switch.js',
+ 'crbug.com/681236': ['/v8/test/mjsunit/wasm/asm-wasm-switch.js'],
+
+ # crbug.com/681241
+ 'crbug.com/681241': [
+ '/v8/test/mjsunit/regress/regress-617526.js',
+ '/v8/test/mjsunit/regress/wasm/regression-02862.js',
+ ],
}
# Ignore by test case pattern. Map from bug->regexp.
@@ -300,9 +308,10 @@ class V8Suppression(Suppression):
return False
def ignore_by_metadata(self, metadata):
- for bug, source in IGNORE_SOURCES.iteritems():
- if source in metadata['sources']:
- return bug
+ for bug, sources in IGNORE_SOURCES.iteritems():
+ for source in sources:
+ if source in metadata['sources']:
+ return bug
return False
def ignore_by_output1(self, output):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698