Issue 26444008: Remove several Page.h includes in preparation for removing page/ dependencies from the rest of core

Issue 26444008: Remove several Page.h includes in preparation for removing page/ dependencies from the rest of core (Closed)

Created:
7 years, 2 months ago by eseidel

Modified:
7 years, 2 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, kenneth.christiansen, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, pdr, f(malita), Stephen Chennney

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove several Page.h includes in preparation for removing page/ dependencies from the rest of core This change doesn't actually do anything, but does remove a bunch of Page.h includes. R=abarth@chromium.org BUG=305811 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159343

Patch Set 1 #

Total comments: 1

Patch Set 2 : Now 100% more buildable on debug #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -28 lines)			Patch
M	Source/core/css/CSSParser-in.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/SelectorChecker.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleAdjuster.cpp	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/FullscreenElementStack.cpp	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLMetaElement-in.cpp	View		5 chunks	+5 lines, -6 lines	0 comments	Download
M	Source/core/html/HTMLObjectElement.cpp	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/core/html/ImageDocument.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/FrameView.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResourceFilter.cpp	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/web/PopupMenuChromium.cpp	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/26444008/diff/1/Source/core/dom/FullscreenElementStack.cpp File Source/core/dom/FullscreenElementStack.cpp (right): https://codereview.chromium.org/26444008/diff/1/Source/core/dom/FullscreenElementStack.cpp#newcode187 Source/core/dom/FullscreenElementStack.cpp:187: // FIXME: Does this need to null-check settings()? ...

7 years, 2 months ago (2013-10-09 23:53:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/26444008/1

7 years, 2 months ago (2013-10-09 23:54:07 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 2 months ago (2013-10-10 03:44:53 UTC) #4

eseidel

7 years, 2 months ago (2013-10-10 16:10:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r159343 (presubmit successful).

Expand Messages | Collapse Messages