Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 264433003: Temporarily disable TimelineBasedMeasurementTest.testTimelineBasedForSmoke. (Closed)

Created:
6 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
ernstm
CC:
chromium-reviews, telemetry+watch_chromium.org, nduca, nednguyen(REVIEW IN OTHER ACC)
Visibility:
Public.

Description

Temporarily disable TimelineBasedMeasurementTest.testTimelineBasedForSmoke. It's failing intermittently, causing jobs to fail the Chromium commit queue. Tested locally with 'python tools/perf/run_tests --browser=release'. BUG=368386 R=ernstm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267035

Patch Set 1 #

Patch Set 2 : Used @test.Disabled instead, based on ernstm's review feedback. #

Patch Set 3 : Fixed and re-tested. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/perf/measurements/timeline_based_measurement_unittest.py View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ken Russell (switch to Gerrit)
PTAL
6 years, 7 months ago (2014-04-30 00:27:38 UTC) #1
ernstm
On 2014/04/30 00:27:38, Ken Russell wrote: > PTAL LGTM
6 years, 7 months ago (2014-04-30 00:45:17 UTC) #2
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 7 months ago (2014-04-30 00:45:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/264433003/40001
6 years, 7 months ago (2014-04-30 00:48:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 00:59:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 00:59:31 UTC) #6
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-04-30 01:42:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r267035.

Powered by Google App Engine
This is Rietveld 408576698