Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: test/unittests/wasm/wasm-opcodes-unittest.cc

Issue 2644323002: [wasm] Use the official opcode names everywhere. (Closed)
Patch Set: [wasm] Use the official opcode names everywhere. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/unittests.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/wasm/wasm-opcodes-unittest.cc
diff --git a/test/unittests/wasm/wasm-opcodes-unittest.cc b/test/unittests/wasm/wasm-opcodes-unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4bb04c71525c478dc0e614656f11fc70adeee7df
--- /dev/null
+++ b/test/unittests/wasm/wasm-opcodes-unittest.cc
@@ -0,0 +1,34 @@
+// Copyright 2017 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "test/unittests/test-utils.h"
+
+#include "src/wasm/wasm-opcodes.h"
+
+namespace v8 {
+namespace internal {
+namespace wasm {
+
+class WasmOpcodesTest : public TestWithZone {};
+
+TEST_F(WasmOpcodesTest, EveryOpcodeHasAName) {
+ static const struct {
+ WasmOpcode opcode;
+ const char* debug_name;
+ } kValues[] = {
+#define DECLARE_ELEMENT(name, opcode, sig) {kExpr##name, "kExpr" #name},
+ FOREACH_OPCODE(DECLARE_ELEMENT)};
+
+ for (size_t i = 0; i < arraysize(kValues); i++) {
+ const char* result = WasmOpcodes::OpcodeName(kValues[i].opcode);
+ if (strcmp("unknown", result) == 0) {
+ EXPECT_TRUE(false) << "WasmOpcodes::OpcodeName(" << kValues[i].debug_name
+ << ") == \"unknown\";"
+ " plazz halp in src/wasm/wasm-opcodes.cc";
+ }
+ }
+}
+} // namespace wasm
+} // namespace internal
+} // namespace v8
« no previous file with comments | « test/unittests/unittests.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698