Issue 2644293004: Fix labeled break statements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2644293004: Fix labeled break statements. (Closed)

Created:
3 years, 11 months ago by Emily Fortuna

Modified:
3 years, 11 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix labeled break statements. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/01406749582d454226654b2b1e62885fbc899fe7

Patch Set 2 : . #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -16 lines)			Patch
M	pkg/compiler/lib/src/kernel/kernel_visitor.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart	View		2 chunks	+30 lines, -15 lines	0 comments	Download
M	tests/compiler/dart2js/kernel/loops_test.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sra1

lgtm https://codereview.chromium.org/2644293004/diff/1/pkg/compiler/lib/src/kernel/kernel_visitor.dart File pkg/compiler/lib/src/kernel/kernel_visitor.dart (right): https://codereview.chromium.org/2644293004/diff/1/pkg/compiler/lib/src/kernel/kernel_visitor.dart#newcode412 pkg/compiler/lib/src/kernel/kernel_visitor.dart:412: print('a target: $statement ${statement.runtimeType}'); remove

3 years, 11 months ago (2017-01-21 00:17:19 UTC) #3

Emily Fortuna

3 years, 11 months ago (2017-01-21 00:18:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
01406749582d454226654b2b1e62885fbc899fe7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 2644293004: Fix labeled break statements. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages