Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 2644233007: DevTools: Use real focus in TreeOutline (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 19 matching lines...) Expand all
30 Components.ObjectPropertiesSection = class extends UI.TreeOutlineInShadow { 30 Components.ObjectPropertiesSection = class extends UI.TreeOutlineInShadow {
31 /** 31 /**
32 * @param {!SDK.RemoteObject} object 32 * @param {!SDK.RemoteObject} object
33 * @param {?string|!Element=} title 33 * @param {?string|!Element=} title
34 * @param {!Components.Linkifier=} linkifier 34 * @param {!Components.Linkifier=} linkifier
35 * @param {?string=} emptyPlaceholder 35 * @param {?string=} emptyPlaceholder
36 * @param {boolean=} ignoreHasOwnProperty 36 * @param {boolean=} ignoreHasOwnProperty
37 * @param {!Array.<!SDK.RemoteObjectProperty>=} extraProperties 37 * @param {!Array.<!SDK.RemoteObjectProperty>=} extraProperties
38 */ 38 */
39 constructor(object, title, linkifier, emptyPlaceholder, ignoreHasOwnProperty, extraProperties) { 39 constructor(object, title, linkifier, emptyPlaceholder, ignoreHasOwnProperty, extraProperties) {
40 super(); 40 super(true);
41 this._object = object; 41 this._object = object;
42 this._editable = true; 42 this._editable = true;
43 this.hideOverflow(); 43 this.hideOverflow();
44 this.setFocusable(false);
pfeldman 2017/01/30 18:43:07 I like it the way it was
einbinder 2017/02/01 22:51:35 Done.
45 this._objectTreeElement = new Components.ObjectPropertiesSection.RootElement ( 44 this._objectTreeElement = new Components.ObjectPropertiesSection.RootElement (
46 object, linkifier, emptyPlaceholder, ignoreHasOwnProperty, extraProperti es); 45 object, linkifier, emptyPlaceholder, ignoreHasOwnProperty, extraProperti es);
47 this.appendChild(this._objectTreeElement); 46 this.appendChild(this._objectTreeElement);
48 if (typeof title === 'string' || !title) { 47 if (typeof title === 'string' || !title) {
49 this.titleElement = this.element.createChild('span'); 48 this.titleElement = this.element.createChild('span');
50 this.titleElement.textContent = title || ''; 49 this.titleElement.textContent = title || '';
51 } else { 50 } else {
52 this.titleElement = title; 51 this.titleElement = title;
53 this.element.appendChild(title); 52 this.element.appendChild(title);
54 } 53 }
(...skipping 1310 matching lines...) Expand 10 before | Expand all | Expand 10 after
1365 } 1364 }
1366 var treeOutlineId = treeElement.treeOutline[Components.ObjectPropertiesSecti onExpandController._treeOutlineId]; 1365 var treeOutlineId = treeElement.treeOutline[Components.ObjectPropertiesSecti onExpandController._treeOutlineId];
1367 result = treeOutlineId + (result ? ':' + result : ''); 1366 result = treeOutlineId + (result ? ':' + result : '');
1368 treeElement[Components.ObjectPropertiesSectionExpandController._cachedPathSy mbol] = result; 1367 treeElement[Components.ObjectPropertiesSectionExpandController._cachedPathSy mbol] = result;
1369 return result; 1368 return result;
1370 } 1369 }
1371 }; 1370 };
1372 1371
1373 Components.ObjectPropertiesSectionExpandController._cachedPathSymbol = Symbol('c achedPath'); 1372 Components.ObjectPropertiesSectionExpandController._cachedPathSymbol = Symbol('c achedPath');
1374 Components.ObjectPropertiesSectionExpandController._treeOutlineId = Symbol('tree OutlineId'); 1373 Components.ObjectPropertiesSectionExpandController._treeOutlineId = Symbol('tree OutlineId');
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698