Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2644233007: DevTools: Use real focus in TreeOutline (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com> 3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 807 matching lines...) Expand 10 before | Expand all | Expand 10 after
818 * @this {Elements.ElementsTreeElement} 818 * @this {Elements.ElementsTreeElement}
819 */ 819 */
820 function moveToNextAttributeIfNeeded(error) { 820 function moveToNextAttributeIfNeeded(error) {
821 if (error) 821 if (error)
822 this._editingCancelled(element, attributeName); 822 this._editingCancelled(element, attributeName);
823 823
824 if (!moveDirection) 824 if (!moveDirection)
825 return; 825 return;
826 826
827 treeOutline.runPendingUpdates(); 827 treeOutline.runPendingUpdates();
828 treeOutline.focus();
pfeldman 2017/01/21 04:57:34 nit: why did the tree lose focus? (seems fragile)
828 829
829 // Search for the attribute's position, and then decide where to move to. 830 // Search for the attribute's position, and then decide where to move to.
830 var attributes = this._node.attributes(); 831 var attributes = this._node.attributes();
831 for (var i = 0; i < attributes.length; ++i) { 832 for (var i = 0; i < attributes.length; ++i) {
832 if (attributes[i].name !== attributeName) 833 if (attributes[i].name !== attributeName)
833 continue; 834 continue;
834 835
835 if (moveDirection === 'backward') { 836 if (moveDirection === 'backward') {
836 if (i === 0) 837 if (i === 0)
837 this._startEditingTagName(); 838 this._startEditingTagName();
(...skipping 725 matching lines...) Expand 10 before | Expand all | Expand 10 after
1563 1564
1564 // A union of HTML4 and HTML5-Draft elements that explicitly 1565 // A union of HTML4 and HTML5-Draft elements that explicitly
1565 // or implicitly (for HTML5) forbid the closing tag. 1566 // or implicitly (for HTML5) forbid the closing tag.
1566 Elements.ElementsTreeElement.ForbiddenClosingTagElements = new Set([ 1567 Elements.ElementsTreeElement.ForbiddenClosingTagElements = new Set([
1567 'area', 'base', 'basefont', 'br', 'canvas', 'col', 'command', 'embed', 'frame', 'hr', 1568 'area', 'base', 'basefont', 'br', 'canvas', 'col', 'command', 'embed', 'frame', 'hr',
1568 'img', 'input', 'keygen', 'link', 'menuitem', 'meta', 'param', 'source', 'track', 'wbr' 1569 'img', 'input', 'keygen', 'link', 'menuitem', 'meta', 'param', 'source', 'track', 'wbr'
1569 ]); 1570 ]);
1570 1571
1571 // These tags we do not allow editing their tag name. 1572 // These tags we do not allow editing their tag name.
1572 Elements.ElementsTreeElement.EditTagBlacklist = new Set(['html', 'head', 'body'] ); 1573 Elements.ElementsTreeElement.EditTagBlacklist = new Set(['html', 'head', 'body'] );
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698