Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 264423002: Make git rebase-update more responsive. (Closed)

Created:
6 years, 7 months ago by iannucci
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Make git rebase-update more responsive. Passes through git-fetch's output instead of buffering it. R=djacques@chromium.org TBR=agable@chromium.org BUG=366375 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269080

Patch Set 1 #

Patch Set 2 : Make rebase-update stream fetch output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M git_rebase_update.py View 1 1 chunk +2 lines, -4 lines 0 comments Download
M testing_support/git_test_utils.py View 1 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
iannucci
PTAL, whoever gets there first.
6 years, 7 months ago (2014-05-08 18:56:40 UTC) #1
dnj
lgtm
6 years, 7 months ago (2014-05-08 19:11:35 UTC) #2
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 7 months ago (2014-05-08 19:15:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/264423002/20001
6 years, 7 months ago (2014-05-08 19:16:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 19:16:12 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-08 19:16:12 UTC) #6
iannucci
On 2014/05/08 19:16:12, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 7 months ago (2014-05-08 19:18:07 UTC) #7
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 7 months ago (2014-05-08 19:18:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/264423002/20001
6 years, 7 months ago (2014-05-08 19:21:07 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-08 19:22:48 UTC) #10
Message was sent while issue was closed.
Change committed as 269080

Powered by Google App Engine
This is Rietveld 408576698