Service worker registration error support

content/common/service_worker_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Message definition file, included multiple times, hence no include guard.
 
 #include "base/strings/string16.h"
 #include "ipc/ipc_message_macros.h"
 #include "ipc/ipc_param_traits.h"
+#include "third_party/WebKit/public/platform/WebServiceWorkerError.h"
 #include "url/gurl.h"
 
+#undef IPC_MESSAGE_EXPORT
+#define IPC_MESSAGE_EXPORT CONTENT_EXPORT
+
 #define IPC_MESSAGE_START ServiceWorkerMsgStart
 
+IPC_ENUM_TRAITS(WebKit::WebServiceWorkerError::ErrorType)
+
 // Messages sent from the child process to the browser.
 
 IPC_MESSAGE_CONTROL4(ServiceWorkerHostMsg_RegisterServiceWorker,
                      int32 /* thread_id */,
                      int32 /* request_id */,
                      GURL /* scope */,
                      GURL /* script_url */)
 
 IPC_MESSAGE_CONTROL3(ServiceWorkerHostMsg_UnregisterServiceWorker,
                      int32 /* thread_id */,
                      int32 /* request_id */,
                      GURL /* scope (url pattern) */)
 
 // Messages sent from the browser to the child process.
 
 // Response to ServiceWorkerMsg_RegisterServiceWorker
 IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_ServiceWorkerRegistered,
                      int32 /* thread_id */,
                      int32 /* request_id */,
                      int64 /* service_worker_id */)
 
 // Response to ServiceWorkerMsg_UnregisterServiceWorker
 IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_ServiceWorkerUnregistered,
                       int32 /* thread_id */,
                       int32 /* request_id */)
+
+// Sent when any kind of registration error occurs during a
+// RegisterServiceWorker / UnregisterServiceWorker handler above. In
+// the future this can expand to include the actual reason for the
+// error, or even be split if there is a significant difference
+// between registration and unregistration errors.

[michaeln, 2013/10/25 21:41:25]

The first sentence looks good enough.

[alecflett, 2013/10/25 23:41:56]

Done.

+IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_ServiceWorkerRegistrationError,
+                     int32 /* thread_id */,
+                     int32 /* request_id */,
+                     WebKit::WebServiceWorkerError::ErrorType /* code */,
+                     string16 /* message */)

[michaeln, 2013/10/25 21:41:25]

should we use utf8 here and upsample at the WebKit API boundary?

[alecflett, 2013/10/25 23:41:56]

It's fairly common to just use the enum and IPC_ENUM_TRAITS and I like the
explicit nature of it.
https://code.google.com/p/chromium/codesearch#search/&q=IPC_ENUM_TRAITS.*WebK...

[michaeln, 2013/10/26 00:41:01]

I was asking about the string value type?

We could use std::string here and rely on WebString::fromUTF8(stdstring). Would
take a little voodoo out of the simple case of returning a simple constant
string value message.

[alecflett, 2013/10/28 17:03:14]

Oh I see. I personally prefer doing the conversion at the point (or at least in
the same process) as where the string is created...