Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2644163002: More ifdefs to make everything build at -O0 and without --gc-sections. (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More ifdefs to make everything build at -O0 and without --gc-sections. R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/508e735b8f978dd991d06dc725b27acb0a29b83f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M runtime/lib/mirrors.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bootstrap_natives.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 11 months ago (2017-01-19 19:26:38 UTC) #2
regis
lgtm and thanks for the quick turnaround.
3 years, 11 months ago (2017-01-19 19:29:33 UTC) #3
rmacnak
3 years, 11 months ago (2017-01-19 20:16:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
508e735b8f978dd991d06dc725b27acb0a29b83f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698