Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: chrome/common/safe_browsing/csd.proto

Issue 2644133005: Include all server redirects in referrer chain (Closed)
Patch Set: nit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This proto file includes: 5 // This proto file includes:
6 // (1) Client side phishing and malware detection request and response 6 // (1) Client side phishing and malware detection request and response
7 // protocol buffers. Those protocol messages should be kept in sync 7 // protocol buffers. Those protocol messages should be kept in sync
8 // with the server implementation. 8 // with the server implementation.
9 // 9 //
10 // (2) Safe Browsing reporting protocol buffers. 10 // (2) Safe Browsing reporting protocol buffers.
(...skipping 398 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 // Referrer url of this entry. 409 // Referrer url of this entry.
410 optional string referrer_url = 4; 410 optional string referrer_url = 4;
411 411
412 // Main frame URL of referrer. 412 // Main frame URL of referrer.
413 optional string referrer_main_frame_url = 5; 413 optional string referrer_main_frame_url = 5;
414 414
415 // If this URL loads in a different tab/frame from previous one. 415 // If this URL loads in a different tab/frame from previous one.
416 optional bool is_retargeting = 6; 416 optional bool is_retargeting = 6;
417 417
418 optional double navigation_time_msec = 7; 418 optional double navigation_time_msec = 7;
419
420 // Set only if server redirects happen in navigation.
421 // The first entry in |server_redirect_chain| should be the original request
Nathan Parker 2017/01/20 23:36:20 Looks like the last entry would be redundant, but
Jialiu Lin 2017/01/21 00:48:27 I think it is less confusing in this way. auk and
422 // url, and the last entry should be the same as |url|.
423 repeated string server_redirect_chain = 8;
419 } // End of URLChainEntry 424 } // End of URLChainEntry
420 425
421 message ClientDownloadResponse { 426 message ClientDownloadResponse {
422 enum Verdict { 427 enum Verdict {
423 // Download is considered safe. 428 // Download is considered safe.
424 SAFE = 0; 429 SAFE = 0;
425 // Download is considered dangerous. Chrome should show a warning to the 430 // Download is considered dangerous. Chrome should show a warning to the
426 // user. 431 // user.
427 DANGEROUS = 1; 432 DANGEROUS = 1;
428 // Download is uncommon. Chrome should display a less severe warning. 433 // Download is uncommon. Chrome should display a less severe warning.
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 optional bool did_proceed = 8; 833 optional bool did_proceed = 8;
829 834
830 // Whether user visited this origin before. 835 // Whether user visited this origin before.
831 optional bool repeat_visit = 9; 836 optional bool repeat_visit = 9;
832 837
833 // The same token in ClientDownloadResponse. This field is only set if its 838 // The same token in ClientDownloadResponse. This field is only set if its
834 // report type is DANGEROUS_DOWNLOAD_RECOVERY, DANGEROUS_DOWNLOAD_WARNING or 839 // report type is DANGEROUS_DOWNLOAD_RECOVERY, DANGEROUS_DOWNLOAD_WARNING or
835 // DANGEROUS_DOWNLOAD_BY_API. 840 // DANGEROUS_DOWNLOAD_BY_API.
836 optional bytes token = 15; 841 optional bytes token = 15;
837 } 842 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698