(Android) Disabling secure/non secure info without net + small cleanup

(Android) Disabling secure/non secure info without net + small cleanup

BUG=682788

[marcin, 2017-01-19 20:01:05]

Description was changed from

==========
Disabling secure / non secure info without network

BUG=
==========

to

==========
Disabling secure / non secure info without network + small cleanup

BUG=682788
==========

[marcin, 2017-01-19 20:01:05]

marcin@mwiacek.com changed reviewers:
+ nyquist@chromium.org

[marcin, 2017-01-19 20:03:03]

Description was changed from

==========
Disabling secure / non secure info without network + small cleanup

BUG=682788
==========

to

==========
(Android) Disabling secure/non secure info without net + small cleanup

BUG=682788
==========

[nyquist, 2017-01-20 18:20:08]

Opened a discussion on the bug.

[marcin, 2017-01-26 10:50:09]

On 2017/01/20 18:20:08, nyquist wrote:
> Opened a discussion on the bug.

Thank you,

bug was opened 6 days ago and change is in fact very simple. is it possible to
speed up the process ?

[nyquist, 2017-01-26 15:51:50]

On 2017/01/26 10:50:09, marcin wrote:
> On 2017/01/20 18:20:08, nyquist wrote:
> > Opened a discussion on the bug.
> 
> Thank you,
> 
> bug was opened 6 days ago and change is in fact very simple. is it possible to
> speed up the process ?

I don't think pinging the review will necessarily help.

[marcin, 2017-02-08 01:29:30]

On 2017/01/26 15:51:50, nyquist wrote:
> On 2017/01/26 10:50:09, marcin wrote:
> > On 2017/01/20 18:20:08, nyquist wrote:
> > > Opened a discussion on the bug.
> > 
> > Thank you,
> > 
> > bug was opened 6 days ago and change is in fact very simple. is it possible
to
> > speed up the process ?
> 
> I don't think pinging the review will necessarily help.

Discussion in bug is stuck (I don't have neither LGTM or no-LGTM although I'm
just fixing obvious  issue), do you know any other route for addressing it?

[marcin, 2017-02-20 19:07:13]

marcin@mwiacek.com changed reviewers:
+ mariakhomenko@chromium.org

[Maria, 2017-02-21 04:15:30]

On 2017/02/20 19:07:14, marcin wrote:

a) Security said on the bug that we'd want consistency across mobile and desktop
for this and I agree.
b) I am not sure, but I think isErrorPage may be true when you attempt to
establish an insecure https connection -- in that case you really don't want to
hide the messaging.

[nyquist, 2017-08-15 19:30:17]

Removing myself as a reviewer for now until there is consensus on the bug.

[nyquist, 2017-08-15 19:37:37]

nyquist@chromium.org changed reviewers:
- nyquist@chromium.org