Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2644133002: Do not sanitize about:blank/#foo & about:blank?foo (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 11e7198d70cf15b155ba0bac452aacadb0a4cd91..8de6942440ce87b3f937e6e5ea1130ec64bfc7cc 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -5469,15 +5469,6 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(
info.urlRequest.checkForBrowserSideNavigation() &&
ShouldMakeNetworkRequestForURL(url)) {
if (info.defaultPolicy == blink::WebNavigationPolicyCurrentTab) {
- if (RenderThreadImpl::current() &&
- RenderThreadImpl::current()->layout_test_mode()) {
- // Layout tests sometimes attempt to load urls of the form
- // about:blank?foo which the browser doesn't expect and will convert to
- // about:blank. Don't send these to the browser.
Charlie Reis 2017/01/19 22:36:35 Awesome. I love getting rid of checks like this.
- if (url.SchemeIs(url::kAboutScheme) && url.path() == "blank")
- return info.defaultPolicy;
- }
-
BeginNavigation(info);
return blink::WebNavigationPolicyHandledByClient;
} else {

Powered by Google App Engine
This is Rietveld 408576698