Do not sanitize about:blank/#foo & about:blank?foo

url/url_util.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef URL_URL_UTIL_H_
 #define URL_URL_UTIL_H_
 
 #include <string>
 #include <vector>
 
 #include "base/strings/string16.h"
 #include "base/strings/string_piece.h"
 #include "url/third_party/mozilla/url_parse.h"
 #include "url/url_canon.h"
 #include "url/url_constants.h"
 #include "url/url_export.h"
 
+class GURL;
+
 namespace url {
 
 // Init ------------------------------------------------------------------------
 
 // Initialization is NOT required, it will be implicitly initialized when first
 // used. However, this implicit initialization is NOT threadsafe. If you are
 // using this library in a threaded environment and don't have a consistent
 // "first call" (an example might be calling Add*Scheme with your special
 // application-specific schemes) then you will want to call initialize before
 // spawning any threads.
@@ skipping 118 matching lines @@
 // the list of allowed schemes for referrers (see AddReferrerScheme).
 URL_EXPORT bool IsReferrerScheme(const char* spec, const Component& scheme);
 
 // Returns true and sets |type| to the SchemeType of the given scheme
 // identified by |scheme| within |spec| if the scheme is in the list of known
 // standard-format schemes (see AddStandardScheme).
 URL_EXPORT bool GetStandardSchemeType(const char* spec,
                                       const Component& scheme,
                                       SchemeType* type);
 
+// Check whether the url is of the form about:blank, about:blank?foo or
+// about:blank/#foo.
+URL_EXPORT bool IsAboutBlank(const GURL& url);

[brettw, 2017/01/26 21:30:43]

url_util is not right right place for this function. This is really the
infrastructure that underlies both GURL and KURL, rather than functions that
operate on URLs. This is probably misleading given the name, but you can see
that there are no other functions dealing with GURL here.

Can you remove this function?

On https://codereview.chromium.org/2584513003/ I recommended adding a
"EqualsIgnoringRef function on GURL. Then you can change the constant to just
"about:blank" and the two callers can call EqualsIgnoringRef(kAboutBlankUrl");

I don't think this will be slower than the current implementation. Are there
cases where this implementation wouldn't work?

+
 // Hosts  ----------------------------------------------------------------------
 
 // Returns true if the |canonicalized_host| matches or is in the same domain as
 // the given |lower_ascii_domain| string. For example, if the canonicalized
 // hostname is "www.google.com", this will return true for "com", "google.com",
 // and "www.google.com" domains.
 //
 // If either of the input StringPieces is empty, the return value is false. The
 // input domain should be a lower-case ASCII string in order to match the
 // canonicalized host.
@@ skipping 85 matching lines @@
 
 // Escapes the given string as defined by the JS method encodeURIComponent. See
 // https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/encodeURIComponent
 URL_EXPORT void EncodeURIComponent(const char* input,
                                    int length,
                                    CanonOutput* output);
 
 }  // namespace url
 
 #endif  // URL_URL_UTIL_H_