Issue 264413003: Fix crash on fast consecutive item moves in the Windows app list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264413003: Fix crash on fast consecutive item moves in the Windows app list. (Closed)

Created:
6 years, 7 months ago by calamity

Modified:
6 years, 7 months ago

Reviewers:
tapted

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@land_cancel_reparent

Visibility:
Public.

More Reviews

Description

Fix crash on fast consecutive item moves in the Windows app list. This CL fixes an issue where view hierarchy changes in the app list would invalidate the drag view in the middle of processing a drag update. This would cause a crash. In order to fix this, check that the drag view is still valid after the view hierarchy changes. BUG=371212 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269259