Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: ios/web/web_state/web_state_impl.h

Issue 2644103004: Remove RequestTracker from WebStateImpl. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/web_state_impl.h
diff --git a/ios/web/web_state/web_state_impl.h b/ios/web/web_state/web_state_impl.h
index ed7214fe7f1c15f62d2545f7dcab5378b17884cf..e0f543be3b043b404e4042f384c99e51c1cae538 100644
--- a/ios/web/web_state/web_state_impl.h
+++ b/ios/web/web_state/web_state_impl.h
@@ -192,27 +192,6 @@ class WebStateImpl : public WebState, public NavigationManagerDelegate {
// allowed to continue by asking its policy deciders. Defaults to true.
bool ShouldAllowResponse(NSURLResponse* response);
- // Request tracker management. For now, this exposes the RequestTracker for
- // embedders to use.
- // TODO(stuartmorgan): RequestTracker should become an internal detail of this
- // class.
-
- // Create a new tracker using |delegate| as its delegate.
- void InitializeRequestTracker(id<CRWRequestTrackerDelegate> delegate);
-
- // Close the request tracker and delete it.
- void CloseRequestTracker();
-
- // Returns the tracker for this WebStateImpl.
- RequestTrackerImpl* GetRequestTracker();
-
- // Lazily creates (if necessary) and returns |request_group_id_|.
- // IMPORTANT: This should not be used for anything other than associating this
- // instance to network requests.
- // This function is only intended to be used in web/.
- // TODO(stuartmorgan): Move this method in an implementation file in web/.
- NSString* GetRequestGroupID();
-
// WebState:
WebStateDelegate* GetDelegate() override;
void SetDelegate(WebStateDelegate* delegate) override;
@@ -351,14 +330,6 @@ class WebStateImpl : public WebState, public NavigationManagerDelegate {
// Returned by reference.
base::string16 empty_string16_;
- // Request tracker associted with this object.
- scoped_refptr<RequestTrackerImpl> request_tracker_;
-
- // A number identifying this object. This number is injected into the user
- // agent to allow the network layer to know which web view requests originated
- // from.
- base::scoped_nsobject<NSString> request_group_id_;
-
// Callbacks associated to command prefixes.
std::map<std::string, ScriptCommandCallback> script_command_callbacks_;

Powered by Google App Engine
This is Rietveld 408576698