Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: ios/chrome/browser/reading_list/url_downloader.h

Issue 2644073005: [ReadingList iOS] Do not store HTTP images when distilling HTTPS pages (Closed)
Patch Set: feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/reading_list/url_downloader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/reading_list/url_downloader.h
diff --git a/ios/chrome/browser/reading_list/url_downloader.h b/ios/chrome/browser/reading_list/url_downloader.h
index 5ed50b283a05e1620e912c6813e931d3925caf5f..d8c9047377cd42da33b5e23a4ad57cd13211b0ac 100644
--- a/ios/chrome/browser/reading_list/url_downloader.h
+++ b/ios/chrome/browser/reading_list/url_downloader.h
@@ -109,6 +109,8 @@ class URLDownloader {
std::string* image_name);
// Saves images in |images| array to disk and replaces references in |html| to
// local path. Returns updated html.
+ // If some images could not be saved, returns an empty string. It is the
+ // responsibility of the caller to clean the partial processing.
std::string SaveAndReplaceImagesInHTML(
const GURL& url,
const std::string& html,
« no previous file with comments | « no previous file | ios/chrome/browser/reading_list/url_downloader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698