Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5870)

Unified Diff: chrome/test/chromedriver/logging_unittest.cc

Issue 2644033004: [chromedriver] Prevent GetLog from returning more than 100,000 at a time. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/chromedriver/logging.cc ('K') | « chrome/test/chromedriver/logging.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/logging_unittest.cc
diff --git a/chrome/test/chromedriver/logging_unittest.cc b/chrome/test/chromedriver/logging_unittest.cc
index 47d0f470f0143da4331292e0b2fca27f56b0cedc..d0ef82b8af195d96a26861f51bf812c0dfbe0dbc 100644
--- a/chrome/test/chromedriver/logging_unittest.cc
+++ b/chrome/test/chromedriver/logging_unittest.cc
@@ -168,3 +168,16 @@ TEST(Logging, GetFirstErrorMessage) {
entry = log.GetFirstErrorMessage();
ASSERT_EQ("first error message", entry);
}
+
+TEST(Logging, GetLotsOfLogs) {
+ WebDriverLog log(WebDriverLog::kBrowserType, Log::kAll);
+ std::string entry;
+ for (size_t i = 0; i < WebDriverLog::kMaxReturnedEntries + 1; i++)
+ log.AddEntry(Log::kError, "info message");
+ std::unique_ptr<base::ListValue> entries = log.GetAndClearEntries();
+ ASSERT_EQ(WebDriverLog::kMaxReturnedEntries, entries->GetSize());
+ entries = log.GetAndClearEntries();
+ ASSERT_EQ(1u, entries->GetSize());
+ entries = log.GetAndClearEntries();
+ ASSERT_EQ(0u, entries->GetSize());
+}
« chrome/test/chromedriver/logging.cc ('K') | « chrome/test/chromedriver/logging.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698