[chromedriver] Prevent GetLog from returning more than 100,000 at a time.

chrome/test/chromedriver/logging.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_CHROMEDRIVER_LOGGING_H_
 #define CHROME_TEST_CHROMEDRIVER_LOGGING_H_
 
 #include <memory>
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/scoped_vector.h"
 #include "base/values.h"
 #include "chrome/test/chromedriver/chrome/log.h"
 
 struct Capabilities;
 class CommandListener;
 class DevToolsEventListener;
 class ListValue;
 struct Session;
 class Status;
 
 // Accumulates WebDriver Logging API entries of a given type and minimum level.
 // See https://code.google.com/p/selenium/wiki/Logging.
 class WebDriverLog : public Log {
  public:
   static const char kBrowserType[];
   static const char kDriverType[];
   static const char kPerformanceType[];
+  static const size_t kMaxReturnedEntries;

[klm, 2017/01/19 20:47:30]

Is this for testing only? I don't believe there is any use for actual callers.
Is there an equivalent of e.g. @VisibleForTesting in Chromium C++, or some
coding pattern for exposing a constant to tests only, without exposing it to
real callers?

[samuong, 2017/01/19 21:15:37]

We could make it private and then friend a test class, wdyt?

[klm, 2017/01/19 21:26:17]

I have no strong opinion, was just pointing out something that I didn't quite
like:) Up to you and Shuotao what to do with it, if anything at all.

 
   // Converts WD wire protocol level name -> Level, false on bad name.
   static bool NameToLevel(const std::string& name, Level* out_level);
 
   // Creates a WebDriverLog with the given type and minimum level.
   WebDriverLog(const std::string& type, Level min_level);
   ~WebDriverLog() override;
 
   // Returns entries accumulated so far, as a ListValue ready for serialization
   // into the wire protocol response to the "/log" command.
@@ skipping 28 matching lines @@
 
 // Creates |Log|s, |DevToolsEventListener|s, and |CommandListener|s based on
 // logging preferences.
 Status CreateLogs(const Capabilities& capabilities,
                   const Session* session,
                   ScopedVector<WebDriverLog>* out_logs,
                   ScopedVector<DevToolsEventListener>* out_devtools_listeners,
                   ScopedVector<CommandListener>* out_command_listeners);
 
 #endif  // CHROME_TEST_CHROMEDRIVER_LOGGING_H_