Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1788)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2643893002: Skip video overlay surface management when in VR. (Closed)
Patch Set: Removed public API changes and changed references to cast to base instead. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.cc ('k') | media/blink/webmediaplayer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index ce8f2725ee2b813aa94e0886dfe200be4c48e5da..419e4dde153d58e60611ff16a8f16db03d9153cb 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2896,13 +2896,6 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
GetWebMediaPlayerDelegate()->AsWeakPtr(),
std::move(media_renderer_factory), url_index_, params);
- // TODO(http://crbug.com/673886): Re-enable overlays with VR shell enabled
- // when VR shell's video reprojection surface is enabled. Remove the setter
- // and put the overlay feature check back in the constructor at that time.
- media_player->SetEnableFullscreenOverlays(
- base::FeatureList::IsEnabled(media::kOverlayFullscreenVideo) &&
- !base::FeatureList::IsEnabled(features::kVrShell));
-
#if defined(OS_ANDROID) // WMPI_CAST
media_player->SetMediaPlayerManager(GetMediaPlayerManager());
media_player->SetDeviceScaleFactor(render_view_->GetDeviceScaleFactor());
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.cc ('k') | media/blink/webmediaplayer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698