Use entities in interceptor_stub_generator.

Use entities in interceptor_stub_generator.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/564476044fd52d8324e322e0c66ecd392f327715

[Johnni Winther, 2017-01-19 15:19:57]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-19 16:48:22]

lgtm

https://codereview.chromium.org/2643863005/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart (left):

https://codereview.chromium.org/2643863005/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart:386: if (element
is ClassElement) {
Just to double-check, this `if` was practically innecessary? (all
TypeConstantValue are defined in terms of a class element, correct?) What if the
type is unresolved?

[Johnni Winther, 2017-01-20 07:57:04]

https://codereview.chromium.org/2643863005/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart (left):

https://codereview.chromium.org/2643863005/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart:386: if (element
is ClassElement) {
On 2017/01/19 16:48:22, Siggi Cherem (dart-lang) wrote:
> Just to double-check, this `if` was practically innecessary? (all
> TypeConstantValue are defined in terms of a class element, correct?) What if
the
> type is unresolved?

All [InterfaceType]s point to a [ClassEntity], if it was unresolved it would
have resulted in a [MalformedType].

[Johnni Winther, 2017-01-20 08:28:11]

Description was changed from

==========
Use entities in interceptor_stub_generator.
==========

to

==========
Use entities in interceptor_stub_generator.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/564476044fd52d8324e322e0c66ecd392f327715
==========

[Johnni Winther, 2017-01-20 08:28:13]

Committed patchset #1 (id:1) manually as
564476044fd52d8324e322e0c66ecd392f327715 (presubmit successful).