Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2643863003: Fix vm-kernel-precompilation builders (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M tools/testing/dart/compiler_configuration.dart View 4 chunks +23 lines, -22 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
kustermann
https://codereview.chromium.org/2643863003/diff/1/tools/testing/dart/compiler_configuration.dart File tools/testing/dart/compiler_configuration.dart (right): https://codereview.chromium.org/2643863003/diff/1/tools/testing/dart/compiler_configuration.dart#newcode339 tools/testing/dart/compiler_configuration.dart:339: return replaceDartFileWith(globalArguments, previousOutput); This line was the issue.
3 years, 11 months ago (2017-01-18 21:41:01 UTC) #2
kustermann
TBR to get buildbot green again
3 years, 11 months ago (2017-01-18 21:41:11 UTC) #3
kustermann
Committed patchset #1 (id:1) manually as 5f9e59f27863d481a93ee804337f4859e60e658a (presubmit successful).
3 years, 11 months ago (2017-01-18 21:41:37 UTC) #5
Vyacheslav Egorov (Google)
3 years, 11 months ago (2017-01-18 22:04:40 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698