Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: chrome/app/mash/BUILD.gn

Issue 2643853005: chromeos: Initial support for crash reporting for chrome --mash (Closed)
Patch Set: deps Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/mash/mash_crash_reporter_client.h » ('j') | chrome/app/mash/mash_runner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/mash/BUILD.gn
diff --git a/chrome/app/mash/BUILD.gn b/chrome/app/mash/BUILD.gn
index bad668e61e77ada30fbd71905012a8ccae7fc8aa..a716123b223bd84c172fb8179097f83743f0c0c4 100644
--- a/chrome/app/mash/BUILD.gn
+++ b/chrome/app/mash/BUILD.gn
@@ -33,7 +33,18 @@ source_set("mash") {
]
if (is_chromeos) {
- deps += [ "//ash/resources" ]
+ sources += [
+ "mash_crash_reporter_client.cc",
+ "mash_crash_reporter_client.h",
+ ]
+ deps += [
+ "//ash/resources",
+ "//components/crash/content/app",
+ "//components/crash/core/common",
+ "//components/upload_list",
+ "//components/version_info:generate_version_info",
+ "//services/ui/gpu",
James Cook 2017/01/19 02:50:17 Also, this is unfortunate. Any thoughts on how to
sadrul 2017/01/19 04:22:11 Maybe use crash_keys::kActiveURL in chrome code in
James Cook 2017/01/19 18:01:18 //chrome/app/mash is not supposed to depend on any
+ ]
}
if (is_linux && !is_android) {
« no previous file with comments | « no previous file | chrome/app/mash/mash_crash_reporter_client.h » ('j') | chrome/app/mash/mash_runner.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698