chromeos: Initial support for crash reporting for chrome --mash

chrome/app/mash/mash_runner.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/mash/mash_runner.h"
 
 #include "base/at_exit.h"
 #include "base/base_paths.h"
 #include "base/base_switches.h"
 #include "base/bind.h"
@@ skipping 28 matching lines @@
 #include "services/service_manager/public/cpp/service_context.h"
 #include "services/service_manager/public/cpp/standalone_service/standalone_service.h"
 #include "services/service_manager/public/interfaces/service_factory.mojom.h"
 #include "services/service_manager/runner/common/client_util.h"
 #include "services/service_manager/runner/common/switches.h"
 #include "services/service_manager/runner/init.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/ui_base_paths.h"
 #include "ui/base/ui_base_switches.h"
 
+#if defined(OS_CHROMEOS)
+#include "chrome/app/mash/mash_crash_reporter_client.h"
+#include "components/crash/content/app/breakpad_linux.h"
+#endif
+
 using service_manager::mojom::ServiceFactory;
 
 namespace {
 
 // kProcessType used to identify child processes.
 const char* kMashChild = "mash-child";
 
 const char kChromeMashServiceName[] = "chrome_mash";
 
 const char kChromeContentBrowserPackageName[] = "chrome_content_browser";
@@ skipping 61 matching lines @@
     for (const base::CommandLine::StringType& arg : command_line->argv()) {
       if (arg != FILE_PATH_LITERAL("--mash"))
         new_argv.push_back(arg);
     }
     *command_line = base::CommandLine(new_argv);
   }
 
   DISALLOW_COPY_AND_ASSIGN(ServiceProcessLauncherDelegateImpl);
 };
 
+#if defined(OS_CHROMEOS)
+// Initializes breakpad crash reporting. MashCrashReporterClient handles
+// registering crash keys.
+void InitializeCrashReporting() {
+  // Intentionally leaked.
+  static MashCrashReporterClient* client = new MashCrashReporterClient;
+  crash_reporter::SetCrashReporterClient(client);

[sadrul, 2017/01/19 04:22:11]

I guess we are deliberately leaking here? Do we need to add some hints to
appease lsan?

[James Cook, 2017/01/19 18:01:18]

Good catch on lsan! Done.

+
+  // For now all standalone services act like the browser process and write
+  // their own in-process crash dumps. When ash and the window server are
+  // sandboxed we will need to hook up the crash signal file descriptor, make
+  // the root process handle dumping, and pass a process type here.
+  const std::string process_type_unused;
+  breakpad::InitCrashReporter(process_type_unused);
+}
+#endif  // defined(OS_CHROMEOS)
+
 }  // namespace
 
 MashRunner::MashRunner() {}
 
 MashRunner::~MashRunner() {}
 
 int MashRunner::Run() {
   base::TaskScheduler::CreateAndSetSimpleTaskScheduler(
       base::SysInfo::NumberOfProcessors());
 
@@ skipping 76 matching lines @@
   base::RunLoop().Run();
 }
 
 int MashMain() {
 #if !defined(OFFICIAL_BUILD) && defined(OS_WIN)
   base::RouteStdioToConsole(false);
 #endif
   // TODO(sky): wire this up correctly.
   service_manager::InitializeLogging();
 
-  std::unique_ptr<base::MessageLoop> message_loop;
 #if defined(OS_LINUX)
   base::AtExitManager exit_manager;
 #endif
+
+#if !defined(OFFICIAL_BUILD)
+  // Initialize stack dumping before initializing sandbox to make sure symbol
+  // names in all loaded libraries will be cached.
+  base::debug::EnableInProcessStackDumping();
+#endif
+
+#if defined(OS_CHROMEOS)
+  // Breakpad installs signal handlers, so crash reporting must be set up after
+  // EnableInProcessStackDumping() resets the signal handlers.
+  InitializeCrashReporting();
+#endif
+
+  std::unique_ptr<base::MessageLoop> message_loop;
   if (!IsChild())
     message_loop.reset(new base::MessageLoop(base::MessageLoop::TYPE_UI));
 
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kTraceToConsole)) {
     base::trace_event::TraceConfig trace_config =
         tracing::GetConfigForTraceToConsole();
     base::trace_event::TraceLog::GetInstance()->SetEnabled(
         trace_config,
         base::trace_event::TraceLog::RECORDING_MODE);
@@ skipping 15 matching lines @@
       command_line->GetSwitchValueASCII(switches::kWaitForDebugger)) {
     return;
   }
 
   // Include the pid as logging may not have been initialized yet (the pid
   // printed out by logging is wrong).
   LOG(WARNING) << "waiting for debugger to attach for service " << service_name
                << " pid=" << base::Process::Current().Pid();
   base::debug::WaitForDebugger(120, true);
 }