Issue 264383006: Guard against stack overflow in Runtime::StringReplaceOneCharWithString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264383006: Guard against stack overflow in Runtime::StringReplaceOneCharWithString. (Closed)

Created:
6 years, 7 months ago by Jarin

Modified:
6 years, 7 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Guard against stack overflow in Runtime::StringReplaceOneCharWithString. Unfortunately, this only triggers with "ulimit -s 1024" (or less), so we cannot have an mjsunit test. The test that fails is test/mjsunit/string-replace-one-char.js on x64.debug. R=ishell@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21262

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/runtime.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jarin

6 years, 7 months ago (2014-05-12 11:36:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21262 (presubmit successful).

Expand Messages | Collapse Messages