Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Side by Side Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2643793002: Fixes to status (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'], 5 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
6 function(dart_sdk, async_helper, expect, unittest, is, require) { 6 function(dart_sdk, async_helper, expect, unittest, is, require) {
7 'use strict'; 7 'use strict';
8 8
9 async_helper = async_helper.async_helper; 9 async_helper = async_helper.async_helper;
10 let minitest = expect.minitest; 10 let minitest = expect.minitest;
(...skipping 14 matching lines...) Expand all
25 // 25 //
26 // Common combinations: 26 // Common combinations:
27 const pass = 'pass'; 27 const pass = 'pass';
28 const fail = 'fail'; 28 const fail = 'fail';
29 const skip_timeout = ['skip', 'timeout']; 29 const skip_timeout = ['skip', 'timeout'];
30 30
31 // Browsers 31 // Browsers
32 const firefox_fail = is.firefox() ? fail : pass; 32 const firefox_fail = is.firefox() ? fail : pass;
33 const chrome_fail = is.chrome() ? fail : pass; 33 const chrome_fail = is.chrome() ? fail : pass;
34 34
35 // These are typically tests with asynchronous exceptions that our
36 // test framework doesn't always catch.
37 const flaky = 'skip';
38
35 // Tests marked with this are still using the deprecated unittest package 39 // Tests marked with this are still using the deprecated unittest package
36 // because they rely on its support for futures and asynchronous tests, which 40 // because they rely on its support for futures and asynchronous tests, which
37 // expect and minitest do not handle. 41 // expect and minitest do not handle.
38 // TODO(rnystrom): Move all of these away from using the async test API so 42 // TODO(rnystrom): Move all of these away from using the async test API so
39 // they can stop using unittest. 43 // they can stop using unittest.
40 const async_unittest = ['unittest', 'skip', 'fail']; 44 const async_unittest = ['unittest', 'skip', 'fail'];
41 45
42 // The number of expected unittest errors should be zero but unfortunately 46 // The number of expected unittest errors should be zero but unfortunately
43 // there are a lot of broken html unittests. 47 // there are a lot of broken html unittests.
44 let num_expected_unittest_fails = 3; 48 let num_expected_unittest_fails = 3;
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 'is_nan_test': fail, 198 'is_nan_test': fail,
195 'issue_22780_test_01_multi': fail, 199 'issue_22780_test_01_multi': fail,
196 'lazy_static3_test': fail, 200 'lazy_static3_test': fail,
197 'least_upper_bound_expansive_test_none_multi': fail, 201 'least_upper_bound_expansive_test_none_multi': fail,
198 'left_shift_test': fail, 202 'left_shift_test': fail,
199 'list_is_test': fail, 203 'list_is_test': fail,
200 'list_literal3_test': fail, 204 'list_literal3_test': fail,
201 'many_generic_instanceof_test': fail, 205 'many_generic_instanceof_test': fail,
202 'map_literal10_test': fail, 206 'map_literal10_test': fail,
203 'map_literal7_test': fail, 207 'map_literal7_test': fail,
204 'memory_swap_test': is.firefox() ? skip_timeout : pass, 208 'memory_swap_test': is.firefox() ? skip_timeout : pass,
vsm 2017/01/18 16:01:18 Apparently, there was some weird char in the origi
205 'method_invocation_test': fail, 209 'method_invocation_test': fail,
206 'mint_arithmetic_test': fail, 210 'mint_arithmetic_test': fail,
207 'mixin_forwarding_constructor3_test': fail, 211 'mixin_forwarding_constructor3_test': fail,
208 'mixin_implements_test': fail, 212 'mixin_implements_test': fail,
209 'mixin_issue10216_2_test': fail, 213 'mixin_issue10216_2_test': fail,
210 'mixin_mixin2_test': fail, 214 'mixin_mixin2_test': fail,
211 'mixin_mixin3_test': fail, 215 'mixin_mixin3_test': fail,
212 'mixin_mixin4_test': fail, 216 'mixin_mixin4_test': fail,
213 'mixin_mixin5_test': fail, 217 'mixin_mixin5_test': fail,
214 'mixin_mixin6_test': fail, 218 'mixin_mixin6_test': fail,
215 'mixin_mixin7_test': fail, 219 'mixin_mixin7_test': fail,
216 'mixin_mixin_bound2_test': fail, 220 'mixin_mixin_bound2_test': fail,
217 'mixin_mixin_bound_test': fail, 221 'mixin_mixin_bound_test': fail,
218 'mixin_mixin_test': fail, 222 'mixin_mixin_test': fail,
219 'mixin_regress_13688_test': fail, 223 'mixin_regress_13688_test': fail,
220 'modulo_test': fail, 224 'modulo_test': fail,
221 'named_parameter_clash_test': fail, 225 'named_parameter_clash_test': fail,
222 'named_parameters_passing_falsy_test': firefox_fail, 226 'named_parameters_passing_falsy_test': firefox_fail,
223 'nan_identical_test': fail, 227 'nan_identical_test': fail,
224 'nested_switch_label_test': fail, 228 'nested_switch_label_test': fail,
225 'number_identifier_test_05_multi': fail, 229 'number_identifier_test_05_multi': fail,
226 'number_identity2_test': fail, 230 'number_identity2_test': fail,
227 'numbers_test': fail, 231 'numbers_test': fail,
228 'redirecting_factory_reflection_test': fail, 232 'redirecting_factory_reflection_test': fail,
229 'regress_16640_test': fail, 233 'regress_16640_test': fail,
230 'regress_18535_test': fail, 234 'regress_18535_test': fail,
231 'regress_22666_test': fail, 235 'regress_22666_test': fail,
232 'regress_22777_test': is.firefox() ? 'skip' : fail, // flake on ff 236 'regress_22777_test': flaky,
vsm 2017/01/18 16:01:17 Flaking on Chrome as well. We're not handling the
233 'setter_no_getter_test_01_multi': fail, 237 'setter_no_getter_test_01_multi': fail,
234 'stack_overflow_stacktrace_test': fail, 238 'stack_overflow_stacktrace_test': fail,
235 'stack_overflow_test': fail, 239 'stack_overflow_test': fail,
236 'stacktrace_rethrow_error_test_none_multi': fail, 240 'stacktrace_rethrow_error_test_none_multi': fail,
237 'stacktrace_rethrow_error_test_withtraceparameter_multi': fail, 241 'stacktrace_rethrow_error_test_withtraceparameter_multi': fail,
238 'stacktrace_test': chrome_fail, 242 'stacktrace_test': chrome_fail,
239 'string_interpolate_null_test': fail, 243 'string_interpolate_null_test': fail,
240 'switch_label2_test': fail, 244 'switch_label2_test': fail,
241 'switch_label_test': fail, 245 'switch_label_test': fail,
242 'switch_try_catch_test': fail, 246 'switch_try_catch_test': fail,
(...skipping 632 matching lines...) Expand 10 before | Expand all | Expand 10 after
875 879
876 for (let action of unittest_tests) { 880 for (let action of unittest_tests) {
877 try { 881 try {
878 action(); 882 action();
879 } catch (e) { 883 } catch (e) {
880 console.error("Caught error tying to setup test:", e); 884 console.error("Caught error tying to setup test:", e);
881 } 885 }
882 } 886 }
883 }); 887 });
884 }); 888 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698