Remove internals.address(node)

third_party/WebKit/LayoutTests/resources/dump-as-markup.js

 /**
  * There are three basic use cases of dumpAsMarkup
  *
  * 1. Dump the entire DOM when the page is loaded
  *    When this script is included but no method of Markup is called,
  *    it dumps the DOM of each frame loaded.
  *
  * 2. Dump the content of a specific element when the page is loaded
  *    When Markup.setNodeToDump is called with some element or the id of some element,
  *    it dumps the content of the specified element as supposed to the entire DOM tree.
@@ skipping 108 matching lines @@
         testRunner.notifyDone();
 }
 
 Markup.useHTML5libOutputFormat = function()
 {
     Markup._useHTML5libOutputFormat = true;
 }
 
 Markup.get = function(node)
 {
-    var shadowRootList = {};
-    var markup = Markup._getShadowHostIfPossible(node, 0, shadowRootList);
+    var markup = Markup._getShadowHostIfPossible(node, 0);
     if (markup)
         return markup.substring(1);
 
     if (!node.firstChild)
         return '| ';
 
     // Don't print any markup for the root node.
     for (var i = 0, len = node.childNodes.length; i < len; i++)
-        markup += Markup._get(node.childNodes[i], 0, shadowRootList);
+        markup += Markup._get(node.childNodes[i], 0);
     return markup.substring(1);
 }
 
 // Returns the markup for the given node. To be used for cases where a test needs
 // to get the markup but not clobber the whole page.
-Markup._get = function(node, depth, shadowRootList)
+Markup._get = function(node, depth)
 {
     var str = Markup._indent(depth);
 
     switch (node.nodeType) {
     case Node.DOCUMENT_TYPE_NODE:
         str += '<!DOCTYPE ' + node.nodeName;
         if (node.publicId || node.systemId) {
             str += ' "' + node.publicId + '"';
             str += ' "' + node.systemId + '"';
         }
@@ skipping 54 matching lines @@
             if (pseudoId)
                 str += Markup._indent(depth + 1) + 'shadow:pseudoId="' + pseudoId + '"';
         }
 
         if (!Markup._useHTML5libOutputFormat)
             if (node.nodeName == "INPUT" || node.nodeName == "TEXTAREA")
                 str += Markup._indent(depth + 1) + 'this.value="' + node.value + '"';
 
         break;
     case Node.DOCUMENT_FRAGMENT_NODE:
-        if (shadowRootList && internals.address(node) in shadowRootList)
+        if (node.constructor.name == "ShadowRoot")
           str += "<shadow:root>";
         else
           str += "content";
     }
 
+    // TODO(esprehn): This should definitely be ==.

[dglazkov, 2017/01/20 16:37:26]

Could you expand on this comment? What does it mean?

[esprehn, 2017/01/20 17:51:50]

It's using single equal instead of double equal. So it's actually assigning to
the read only namespaceURI field which makes this always true.

[dglazkov, 2017/01/23 04:29:36]

Oh, I missed it. I was looking at the node.tagName condition.  Yup.

     if (node.namespaceURI = 'http://www.w3.org/1999/xhtml' && node.tagName == 'TEMPLATE')
-        str += Markup._get(node.content, depth + 1, shadowRootList);
+        str += Markup._get(node.content, depth + 1);
 
     for (var i = 0, len = node.childNodes.length; i < len; i++) {
         var selection = Markup._getSelectionMarker(node, i);
         if (selection)
             str += Markup._indent(depth + 1) + selection;
 
-        str += Markup._get(node.childNodes[i], depth + 1, shadowRootList);
+        str += Markup._get(node.childNodes[i], depth + 1);
     }
     
-    str += Markup._getShadowHostIfPossible(node, depth, shadowRootList);
+    str += Markup._getShadowHostIfPossible(node, depth);
     
     var selection = Markup._getSelectionMarker(node, i);
     if (selection)
         str += Markup._indent(depth + 1) + selection;
 
     return str;
 }
 
-Markup._getShadowHostIfPossible = function (node, depth, shadowRootList)
+Markup._getShadowHostIfPossible = function (node, depth)
 {
     if (!Markup._useHTML5libOutputFormat && node.nodeType == Node.ELEMENT_NODE && window.internals) {
         var root = window.internals.shadowRoot(node);
         if (root) {
-            shadowRootList[internals.address(root)] = true;
-            return Markup._get(root, depth + 1, shadowRootList);
+            return Markup._get(root, depth + 1);
         }
     }
     return '';
 }
 
 Markup._namespace = function(node)
 {
     if (Markup._NAMESPACE_URI_MAP[node.namespaceURI])
         return Markup._NAMESPACE_URI_MAP[node.namespaceURI] + ' ';
     return '';
@@ skipping 94 matching lines @@
             return Markup._SELECTION_CARET;
         else
             return Markup._SELECTION_ANCHOR;
     } else if (index == sel.focusOffset && node == sel.focusNode)
         return Markup._SELECTION_FOCUS;
 
     return '';
 }
 
 window.addEventListener('load', Markup.notifyDone, false);