ios/web_view/internal/criwv_web_main_delegate.mm - Issue 2643773005: Upstream ios/web_view source code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web_view/internal/criwv_web_main_delegate.mm

Issue 2643773005: Upstream ios/web_view source code. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #import "ios/web_view/internal/criwv_web_main_delegate.h"

	6

	7 #import "ios/web_view/internal/criwv_web_client.h"

	8 #import "ios/web_view/public/criwv_delegate.h"

	9

	10 namespace ios_web_view {

	11

	12 CRIWVWebMainDelegate::CRIWVWebMainDelegate(id<CRIWVDelegate> delegate) {
	sdefresne 2017/01/20 10:28:12 nit: CRIWVWebMainDelegate::CRIWVWebMainDelegate(i nit: CRIWVWebMainDelegate::CRIWVWebMainDelegate(id<CRIWVDelegate> delegate) : delegate_(delegate) {} michaeldo 2017/01/24 22:35:25 Done in dep CL. Show quoted text On 2017/01/20 10:28:12, sdefresne wrote: > nit: > > CRIWVWebMainDelegate::CRIWVWebMainDelegate(id<CRIWVDelegate> delegate) > : delegate_(delegate) {} Done in dep CL.
	13 delegate_ = delegate;

	14 }

	15

	16 CRIWVWebMainDelegate::~CRIWVWebMainDelegate() {}

	17

	18 void CRIWVWebMainDelegate::BasicStartupComplete() {

	19 web_client_.reset(new CRIWVWebClient(delegate_));
	sdefresne 2017/01/20 10:28:12 nit: web_client_ = base::MakeUnique<CRIWVWebClient nit: web_client_ = base::MakeUnique<CRIWVWebClient>(delegate_); michaeldo 2017/01/24 22:35:25 Done in dep CL. Show quoted text On 2017/01/20 10:28:12, sdefresne wrote: > nit: web_client_ = base::MakeUnique<CRIWVWebClient>(delegate_); Done in dep CL.
	20 web::SetWebClient(web_client_.get());

	21 }

	22

	23 } // namespace ios_web_view

OLD	NEW